From f065c170ab550de1adb58fd9224ee9039f56e23a Mon Sep 17 00:00:00 2001
From: eileen <emcnaughton@wikimedia.org>
Date: Wed, 18 Jul 2018 21:28:09 +1200
Subject: [PATCH] Move paymentTableID to processor class

paymentid
---
 CRM/Export/BAO/Export.php          | 40 ++----------------------------
 CRM/Export/BAO/ExportProcessor.php |  2 +-
 2 files changed, 3 insertions(+), 39 deletions(-)

diff --git a/CRM/Export/BAO/Export.php b/CRM/Export/BAO/Export.php
index 96615a9da9..7614d268c4 100644
--- a/CRM/Export/BAO/Export.php
+++ b/CRM/Export/BAO/Export.php
@@ -256,41 +256,6 @@ class CRM_Export_BAO_Export {
     return $groupBy;
   }
 
-  /**
-   * Define extra properties for the export based on query mode
-   *
-   * @param string $queryMode
-   *   Query Mode
-   * @return array $extraProperties
-   *   Extra Properties
-   */
-  public static function defineExtraProperties($queryMode) {
-    switch ($queryMode) {
-      case CRM_Contact_BAO_Query::MODE_EVENT:
-        $paymentTableId = 'participant_id';
-        break;
-
-      case CRM_Contact_BAO_Query::MODE_MEMBER:
-        $paymentTableId = 'membership_id';
-        break;
-
-      case CRM_Contact_BAO_Query::MODE_PLEDGE:
-        $paymentTableId = 'pledge_payment_id';
-        break;
-
-      case CRM_Contact_BAO_Query::MODE_CASE:
-        $paymentTableId = '';
-        break;
-
-      default:
-        $paymentTableId = '';
-    }
-    $extraProperties = array(
-      'paymentTableId' => $paymentTableId,
-    );
-    return $extraProperties;
-  }
-
   /**
    * Get the list the export fields.
    *
@@ -344,6 +309,8 @@ class CRM_Export_BAO_Export {
     $processor = new CRM_Export_BAO_ExportProcessor($exportMode, $fields, $queryOperator);
     $returnProperties = array();
     $selectedPaymentFields = FALSE;
+    // @todo - this variable is overwritten later - it should be wholly definable in the processor fn.
+    $paymentTableId = $processor->getPaymentTableID();
 
     $phoneTypes = CRM_Core_PseudoConstant::get('CRM_Core_DAO_Phone', 'phone_type_id');
     // Warning - this imProviders var is used in a somewhat fragile way - don't rename it
@@ -441,9 +408,6 @@ class CRM_Export_BAO_Export {
         }
       }
 
-      $extraProperties = self::defineExtraProperties($queryMode);
-      $paymentTableId = $extraProperties['paymentTableId'];
-
       $returnProperties = array_merge($returnProperties, $processor->getAdditionalReturnProperties());
 
       if ($queryMode != CRM_Contact_BAO_Query::MODE_CONTACTS) {
diff --git a/CRM/Export/BAO/ExportProcessor.php b/CRM/Export/BAO/ExportProcessor.php
index e5d21a9177..449792fdb3 100644
--- a/CRM/Export/BAO/ExportProcessor.php
+++ b/CRM/Export/BAO/ExportProcessor.php
@@ -252,7 +252,7 @@ class CRM_Export_BAO_ExportProcessor {
    */
   public function isExportPaymentFields() {
     if ($this->getRequestedFields() === NULL
-      &&  in_array($this->getExportMode(), [
+      &&  in_array($this->getQueryMode(), [
         CRM_Contact_BAO_Query::MODE_EVENT,
         CRM_Contact_BAO_Query::MODE_MEMBER,
         CRM_Contact_BAO_Query::MODE_PLEDGE,
-- 
2.25.1