From e99eacaca21d8f4421958313c888fb337f57a8da Mon Sep 17 00:00:00 2001 From: Bradley Taylor Date: Mon, 2 Jan 2023 16:18:47 +0000 Subject: [PATCH] (REF) Remove _tagElement dynamic property --- CRM/Activity/Form/Task/AddToTag.php | 2 +- CRM/Activity/Form/Task/RemoveFromTag.php | 2 +- CRM/Contact/Form/Search.php | 1 - CRM/Contact/Form/Task/AddToTag.php | 2 +- CRM/Contact/Form/Task/RemoveFromTag.php | 2 +- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/CRM/Activity/Form/Task/AddToTag.php b/CRM/Activity/Form/Task/AddToTag.php index 51af8f1b63..d3fa1d0e10 100644 --- a/CRM/Activity/Form/Task/AddToTag.php +++ b/CRM/Activity/Form/Task/AddToTag.php @@ -48,7 +48,7 @@ class CRM_Activity_Form_Task_AddToTag extends CRM_Activity_Form_Task { $this->_tags = CRM_Core_BAO_Tag::getTags('civicrm_activity'); foreach ($this->_tags as $tagID => $tagName) { - $this->_tagElement = &$this->addElement('checkbox', "tag[$tagID]", NULL, $tagName); + $this->addElement('checkbox', "tag[$tagID]", NULL, $tagName); } $parentNames = CRM_Core_BAO_Tag::getTagSet('civicrm_activity'); diff --git a/CRM/Activity/Form/Task/RemoveFromTag.php b/CRM/Activity/Form/Task/RemoveFromTag.php index 757c1c9525..db26fa0a20 100644 --- a/CRM/Activity/Form/Task/RemoveFromTag.php +++ b/CRM/Activity/Form/Task/RemoveFromTag.php @@ -46,7 +46,7 @@ class CRM_Activity_Form_Task_RemoveFromTag extends CRM_Activity_Form_Task { // add select for tag $this->_tags = CRM_Core_BAO_Tag::getTags('civicrm_activity'); foreach ($this->_tags as $tagID => $tagName) { - $this->_tagElement = &$this->addElement('checkbox', "tag[$tagID]", NULL, $tagName); + $this->addElement('checkbox', "tag[$tagID]", NULL, $tagName); } $parentNames = CRM_Core_BAO_Tag::getTagSet('civicrm_activity'); diff --git a/CRM/Contact/Form/Search.php b/CRM/Contact/Form/Search.php index 7a139d3b4a..475366a5b9 100644 --- a/CRM/Contact/Form/Search.php +++ b/CRM/Contact/Form/Search.php @@ -78,7 +78,6 @@ class CRM_Contact_Form_Search extends CRM_Core_Form_Search { * @var array */ public $_tag; - public $_tagElement; /** * The params used for search. diff --git a/CRM/Contact/Form/Task/AddToTag.php b/CRM/Contact/Form/Task/AddToTag.php index 2aa3ed6ff6..2001a39ac7 100644 --- a/CRM/Contact/Form/Task/AddToTag.php +++ b/CRM/Contact/Form/Task/AddToTag.php @@ -46,7 +46,7 @@ class CRM_Contact_Form_Task_AddToTag extends CRM_Contact_Form_Task { $this->_tags = CRM_Core_BAO_Tag::getTags(); foreach ($this->_tags as $tagID => $tagName) { - $this->_tagElement = &$this->addElement('checkbox', "tag[$tagID]", NULL, $tagName); + $this->addElement('checkbox', "tag[$tagID]", NULL, $tagName); } $parentNames = CRM_Core_BAO_Tag::getTagSet('civicrm_contact'); diff --git a/CRM/Contact/Form/Task/RemoveFromTag.php b/CRM/Contact/Form/Task/RemoveFromTag.php index 957706f53a..2c2c4d6683 100644 --- a/CRM/Contact/Form/Task/RemoveFromTag.php +++ b/CRM/Contact/Form/Task/RemoveFromTag.php @@ -41,7 +41,7 @@ class CRM_Contact_Form_Task_RemoveFromTag extends CRM_Contact_Form_Task { // add select for tag $this->_tags = CRM_Core_BAO_Tag::getTags(); foreach ($this->_tags as $tagID => $tagName) { - $this->_tagElement = &$this->addElement('checkbox', "tag[$tagID]", NULL, $tagName); + $this->addElement('checkbox', "tag[$tagID]", NULL, $tagName); } $parentNames = CRM_Core_BAO_Tag::getTagSet('civicrm_contact'); -- 2.25.1