From e813005b4602e21000f12a6e6399d2b104448eba Mon Sep 17 00:00:00 2001 From: eileen Date: Mon, 2 Nov 2020 13:03:28 +1300 Subject: [PATCH] [REF] Remove silly if Checking component AND contributionRecur is silly - the latter will only be set if relevant so remove the extra if --- CRM/Core/Payment/PayPalIPN.php | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/CRM/Core/Payment/PayPalIPN.php b/CRM/Core/Payment/PayPalIPN.php index 99a77d2aed..360086b853 100644 --- a/CRM/Core/Payment/PayPalIPN.php +++ b/CRM/Core/Payment/PayPalIPN.php @@ -328,18 +328,17 @@ class CRM_Core_Payment_PayPalIPN extends CRM_Core_Payment_BaseIPN { $input['payment_processor_id'] = $paymentProcessorID; - if ($component == 'contribute') { - if ($ids['contributionRecur']) { - // check if first contribution is completed, else complete first contribution - $first = TRUE; - $completedStatusId = CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_Contribution', 'contribution_status_id', 'Completed'); - if ($objects['contribution']->contribution_status_id == $completedStatusId) { - $first = FALSE; - } - $this->recur($input, $ids, $objects, $first); - return; + if (!empty($ids['contributionRecur'])) { + // check if first contribution is completed, else complete first contribution + $first = TRUE; + $completedStatusId = CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_Contribution', 'contribution_status_id', 'Completed'); + if ($objects['contribution']->contribution_status_id == $completedStatusId) { + $first = FALSE; } + $this->recur($input, $ids, $objects, $first); + return; } + $status = $input['paymentStatus']; if ($status === 'Denied' || $status === 'Failed' || $status === 'Voided') { $this->failed($objects); -- 2.25.1