From e3b80b2cc0a45737954a5f1a691bae2ab43ee8a1 Mon Sep 17 00:00:00 2001 From: Andrew Engelbrecht Date: Tue, 19 Apr 2022 18:53:34 -0400 Subject: [PATCH] comment and function name change for clarification --- lib/Auth/Source/FSFDrupalAuth.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Auth/Source/FSFDrupalAuth.php b/lib/Auth/Source/FSFDrupalAuth.php index 5f6d8d3..ad3c566 100644 --- a/lib/Auth/Source/FSFDrupalAuth.php +++ b/lib/Auth/Source/FSFDrupalAuth.php @@ -279,7 +279,10 @@ class FSFDrupalAuth extends \SimpleSAML\Module\core\Auth\UserPassBase // query for access to board nomination process // - $meets_a_criterion = function ($all_contribs, $amount) { + // $all_contribs: whether to include all contrib types in total + // ... false means only membership donations are counted. + // $amount: donation total threshold for qualifying + $meets_a_donation_criterion = function ($all_contribs, $amount) { $ranged_membership_donation_total = $this->query_db('query_nomination_process_donations', @@ -299,7 +302,7 @@ class FSFDrupalAuth extends \SimpleSAML\Module\core\Auth\UserPassBase return false; }; - if ($meets_a_criterion(true, 5) || $meets_a_criterion(false, 5)) { + if ($meets_a_donation_criterion(true, 5) || $meets_a_donation_criterion(false, 5)) { $attributes['nomination_process'] = ['true']; } else { $attributes['nomination_process'] = ['false']; -- 2.25.1