From da8d3d49ea50b3b00e613d359180e7a6e666c93f Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Fri, 6 May 2022 07:59:07 +1200 Subject: [PATCH] [REF] [Import] Remove another good intention - conflict There is all sorts of handling for 'conflict' - but a conflict return code is never generated --- CRM/Activity/Import/Form/Preview.php | 11 -------- CRM/Activity/Import/Form/Summary.php | 5 +--- CRM/Activity/Import/Parser/Activity.php | 27 +++---------------- CRM/Contact/Import/Form/Preview.php | 12 --------- CRM/Contact/Import/Form/Summary.php | 5 +--- CRM/Contact/Import/ImportJob.php | 1 - CRM/Contact/Import/Parser/Contact.php | 21 +-------------- CRM/Contribute/Import/Form/Preview.php | 11 -------- CRM/Contribute/Import/Form/Summary.php | 5 +--- CRM/Contribute/Import/Parser/Contribution.php | 25 +---------------- CRM/Custom/Import/Form/Preview.php | 11 -------- CRM/Custom/Import/Parser/Api.php | 27 +++---------------- CRM/Event/Import/Form/Preview.php | 11 -------- CRM/Event/Import/Form/Summary.php | 5 +--- CRM/Event/Import/Parser/Participant.php | 25 +---------------- CRM/Import/Forms.php | 2 +- CRM/Import/Parser.php | 27 ------------------- CRM/Member/Import/Form/Preview.php | 11 -------- CRM/Member/Import/Form/Summary.php | 5 +--- CRM/Member/Import/Parser/Membership.php | 22 +-------------- .../CRM/Activity/Import/Form/Preview.tpl | 18 ------------- .../CRM/Activity/Import/Form/Summary.tpl | 20 -------------- templates/CRM/Contact/Import/Form/Preview.tpl | 6 ----- templates/CRM/Contact/Import/Form/Summary.tpl | 20 -------------- .../CRM/Contribute/Import/Form/Preview.tpl | 18 ------------- .../CRM/Contribute/Import/Form/Summary.tpl | 20 -------------- templates/CRM/Event/Import/Form/Preview.tpl | 18 ------------- templates/CRM/Event/Import/Form/Summary.tpl | 20 -------------- templates/CRM/Member/Import/Form/Preview.tpl | 18 ------------- templates/CRM/Member/Import/Form/Summary.tpl | 20 -------------- 30 files changed, 16 insertions(+), 431 deletions(-) diff --git a/CRM/Activity/Import/Form/Preview.php b/CRM/Activity/Import/Form/Preview.php index 75cd9db82e..e991b978e0 100644 --- a/CRM/Activity/Import/Form/Preview.php +++ b/CRM/Activity/Import/Form/Preview.php @@ -29,7 +29,6 @@ class CRM_Activity_Import_Form_Preview extends CRM_Import_Form_Preview { $dataValues = $this->get('dataValues'); $mapper = $this->get('mapper'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $mismatchCount = $this->get('unMatchCount'); // Get the mapping name displayed if the mappingId is set. @@ -46,11 +45,6 @@ class CRM_Activity_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } - if ($conflictRowCount) { - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Activity_Import_Parser_Activity'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - } - if ($mismatchCount) { $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Activity_Import_Parser_Activity'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); @@ -63,9 +57,7 @@ class CRM_Activity_Import_Form_Preview extends CRM_Import_Form_Preview { 'totalRowCount', 'validRowCount', 'invalidRowCount', - 'conflictRowCount', 'downloadErrorRecordsUrl', - 'downloadConflictRecordsUrl', 'downloadMismatchRecordsUrl', ]; $this->setStatusUrl(); @@ -83,7 +75,6 @@ class CRM_Activity_Import_Form_Preview extends CRM_Import_Form_Preview { public function postProcess() { $fileName = $this->controller->exportValue('DataSource', 'uploadFile'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $onDuplicate = $this->get('onDuplicate'); $mapper = $this->controller->exportValue('MapField', 'mapper'); @@ -139,8 +130,6 @@ class CRM_Activity_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('errorFile', $errorFile); $urlParams = 'type=' . CRM_Import_Parser::ERROR . '&parser=CRM_Activity_Import_Parser_Activity'; $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Activity_Import_Parser_Activity'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Activity_Import_Parser_Activity'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } diff --git a/CRM/Activity/Import/Form/Summary.php b/CRM/Activity/Import/Form/Summary.php index e2543665cc..a4c9b66e97 100644 --- a/CRM/Activity/Import/Form/Summary.php +++ b/CRM/Activity/Import/Form/Summary.php @@ -33,7 +33,6 @@ class CRM_Activity_Import_Form_Summary extends CRM_Import_Form_Summary { $this->set('totalRowCount', $totalRowCount); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $duplicateRowCount = $this->get('duplicateRowCount'); $onDuplicate = $this->get('onDuplicate'); $mismatchCount = $this->get('unMatchCount'); @@ -68,7 +67,7 @@ class CRM_Activity_Import_Form_Summary extends CRM_Import_Form_Summary { // Only subtract dupes from successful import if we're skipping. $this->set('validRowCount', $totalRowCount - $invalidRowCount - - $conflictRowCount - $duplicateRowCount - $mismatchCount + $duplicateRowCount - $mismatchCount ); } $this->assign('dupeActionString', $dupeActionString); @@ -77,8 +76,6 @@ class CRM_Activity_Import_Form_Summary extends CRM_Import_Form_Summary { 'totalRowCount', 'validRowCount', 'invalidRowCount', - 'conflictRowCount', - 'downloadConflictRecordsUrl', 'downloadErrorRecordsUrl', 'duplicateRowCount', 'downloadDuplicateRecordsUrl', diff --git a/CRM/Activity/Import/Parser/Activity.php b/CRM/Activity/Import/Parser/Activity.php index 19d40ae451..19f4361ebe 100644 --- a/CRM/Activity/Import/Parser/Activity.php +++ b/CRM/Activity/Import/Parser/Activity.php @@ -485,11 +485,10 @@ class CRM_Activity_Import_Parser_Activity extends CRM_Import_Parser { $this->_lineCount = 0; $this->_invalidRowCount = $this->_validCount = 0; - $this->_totalCount = $this->_conflictCount = 0; + $this->_totalCount = 0; $this->_errors = []; $this->_warnings = []; - $this->_conflicts = []; $this->_fileSize = number_format(filesize($fileName) / 1024.0, 2); @@ -571,16 +570,6 @@ class CRM_Activity_Import_Parser_Activity extends CRM_Import_Parser { $this->_errors[] = $values; } - if ($returnCode & self::CONFLICT) { - $this->_conflictCount++; - $recordNumber = $this->_lineCount; - if ($this->_haveColumnHeader) { - $recordNumber--; - } - array_unshift($values, $recordNumber); - $this->_conflicts[] = $values; - } - if ($returnCode & self::DUPLICATE) { $this->_duplicateCount++; $recordNumber = $this->_lineCount; @@ -620,14 +609,7 @@ class CRM_Activity_Import_Parser_Activity extends CRM_Import_Parser { $this->_errorFileName = self::errorFileName(self::ERROR); self::exportCSV($this->_errorFileName, $headers, $this->_errors); } - if ($this->_conflictCount) { - $headers = array_merge( - [ts('Line Number'), ts('Reason')], - $customHeaders - ); - $this->_conflictFileName = self::errorFileName(self::CONFLICT); - self::exportCSV($this->_conflictFileName, $headers, $this->_conflicts); - } + if ($this->_duplicateCount) { $headers = array_merge( [ts('Line Number'), ts('View Activity History URL')], @@ -700,14 +682,11 @@ class CRM_Activity_Import_Parser_Activity extends CRM_Import_Parser { $store->set('totalRowCount', $this->_totalCount); $store->set('validRowCount', $this->_validCount); $store->set('invalidRowCount', $this->_invalidRowCount); - $store->set('conflictRowCount', $this->_conflictCount); if ($this->_invalidRowCount) { $store->set('errorsFileName', $this->_errorFileName); } - if ($this->_conflictCount) { - $store->set('conflictsFileName', $this->_conflictFileName); - } + if (isset($this->_rows) && !empty($this->_rows)) { $store->set('dataValues', $this->_rows); } diff --git a/CRM/Contact/Import/Form/Preview.php b/CRM/Contact/Import/Form/Preview.php index 922745ad82..931cd856ad 100644 --- a/CRM/Contact/Import/Form/Preview.php +++ b/CRM/Contact/Import/Form/Preview.php @@ -34,7 +34,6 @@ class CRM_Contact_Import_Form_Preview extends CRM_Import_Form_Preview { * @throws \CRM_Core_Exception */ public function preProcess() { - $conflictRowCount = $this->get('conflictRowCount'); $mismatchCount = $this->get('unMatchCount'); $columnNames = $this->get('columnNames'); $this->_disableUSPS = $this->get('disableUSPS'); @@ -66,12 +65,6 @@ class CRM_Contact_Import_Form_Preview extends CRM_Import_Form_Preview { $this->assign('validRowCount', $this->getRowCount(CRM_Import_Parser::VALID)); $this->assign('totalRowCount', $this->getRowCount([])); - // @todo conflict rows are still being output in the parser & not updating the temp table - fix - if ($conflictRowCount) { - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Contact_Import_Parser_Contact'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - } - if ($mismatchCount) { $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Contact_Import_Parser_Contact'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); @@ -185,7 +178,6 @@ class CRM_Contact_Import_Form_Preview extends CRM_Import_Form_Preview { $importJobParams = array( 'doGeocodeAddress' => $this->controller->exportValue('DataSource', 'doGeocodeAddress'), 'invalidRowCount' => $this->get('invalidRowCount'), - 'conflictRowCount' => $this->get('conflictRowCount'), 'onDuplicate' => $this->get('onDuplicate'), 'dedupe' => $this->getSubmittedValue('dedupe_rule_id'), 'newGroupName' => $this->controller->exportValue($this->_name, 'newGroupName'), @@ -251,10 +243,6 @@ class CRM_Contact_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('errorFile', $errorFile); - // @todo - these should use the new url but are not reliably updating the table yet. - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Contact_Import_Parser_Contact'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Contact_Import_Parser_Contact'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } diff --git a/CRM/Contact/Import/Form/Summary.php b/CRM/Contact/Import/Form/Summary.php index ab526d4e01..ab86d5bcda 100644 --- a/CRM/Contact/Import/Form/Summary.php +++ b/CRM/Contact/Import/Form/Summary.php @@ -32,7 +32,6 @@ class CRM_Contact_Import_Form_Summary extends CRM_Import_Form_Summary { $totalRowCount += $relatedCount; $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $duplicateRowCount = $this->get('duplicateRowCount'); $onDuplicate = $this->get('onDuplicate'); $mismatchCount = $this->get('unMatchCount'); @@ -75,14 +74,12 @@ class CRM_Contact_Import_Form_Summary extends CRM_Import_Form_Summary { } //now we also create relative contact in update and fill mode $this->set('validRowCount', $totalRowCount - $invalidRowCount - - $conflictRowCount - $duplicateRowCount - $mismatchCount + $duplicateRowCount - $mismatchCount ); $this->assign('dupeActionString', $dupeActionString); $properties = [ - 'conflictRowCount', - 'downloadConflictRecordsUrl', 'downloadErrorRecordsUrl', 'duplicateRowCount', 'downloadDuplicateRecordsUrl', diff --git a/CRM/Contact/Import/ImportJob.php b/CRM/Contact/Import/ImportJob.php index 36fe0f835a..f9f3c49cc9 100644 --- a/CRM/Contact/Import/ImportJob.php +++ b/CRM/Contact/Import/ImportJob.php @@ -26,7 +26,6 @@ class CRM_Contact_Import_ImportJob { protected $_doGeocodeAddress; protected $_invalidRowCount; - protected $_conflictRowCount; protected $_onDuplicate; protected $_dedupe; protected $_newGroupName; diff --git a/CRM/Contact/Import/Parser/Contact.php b/CRM/Contact/Import/Parser/Contact.php index 78138d4a25..a87437f035 100644 --- a/CRM/Contact/Import/Parser/Contact.php +++ b/CRM/Contact/Import/Parser/Contact.php @@ -2576,11 +2576,10 @@ class CRM_Contact_Import_Parser_Contact extends CRM_Import_Parser { $this->_rowCount = 0; $this->_invalidRowCount = $this->_validCount = 0; - $this->_totalCount = $this->_conflictCount = 0; + $this->_totalCount = 0; $this->_errors = []; $this->_warnings = []; - $this->_conflicts = []; $this->_unparsedAddresses = []; $this->_tableName = $tableName = $this->getUserJob()['metadata']['DataSource']['table_name']; @@ -2672,12 +2671,6 @@ class CRM_Contact_Import_Parser_Contact extends CRM_Import_Parser { $this->_errors[] = $values; } - if ($returnCode & self::CONFLICT) { - $this->_conflictCount++; - array_unshift($values, $this->_rowCount); - $this->_conflicts[] = $values; - } - if ($returnCode & self::NO_MATCH) { $this->_unMatchCount++; array_unshift($values, $this->_rowCount); @@ -2715,14 +2708,6 @@ class CRM_Contact_Import_Parser_Contact extends CRM_Import_Parser { } } - if ($this->_conflictCount) { - $headers = array_merge([ - ts('Line Number'), - ts('Reason'), - ], $customHeaders); - $this->_conflictFileName = self::errorFileName(self::CONFLICT); - self::exportCSV($this->_conflictFileName, $headers, $this->_conflicts); - } if ($this->_unMatchCount) { $headers = array_merge([ ts('Line Number'), @@ -3039,7 +3024,6 @@ class CRM_Contact_Import_Parser_Contact extends CRM_Import_Parser { $store->set('totalRowCount', $this->_totalCount); $store->set('validRowCount', $this->_validCount); $store->set('invalidRowCount', $this->_invalidRowCount); - $store->set('conflictRowCount', $this->_conflictCount); $store->set('unMatchCount', $this->_unMatchCount); switch ($this->_contactType) { @@ -3055,9 +3039,6 @@ class CRM_Contact_Import_Parser_Contact extends CRM_Import_Parser { $store->set('contactType', CRM_Import_Parser::CONTACT_ORGANIZATION); } - if ($this->_conflictCount) { - $store->set('conflictsFileName', $this->_conflictFileName); - } if (isset($this->_rows) && !empty($this->_rows)) { $store->set('dataValues', $this->_rows); } diff --git a/CRM/Contribute/Import/Form/Preview.php b/CRM/Contribute/Import/Form/Preview.php index b9abde34ac..6640b01d19 100644 --- a/CRM/Contribute/Import/Form/Preview.php +++ b/CRM/Contribute/Import/Form/Preview.php @@ -31,7 +31,6 @@ class CRM_Contribute_Import_Form_Preview extends CRM_Import_Form_Preview { $softCreditFields = $this->get('softCreditFields'); $mapperSoftCreditType = $this->get('mapperSoftCreditType'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $mismatchCount = $this->get('unMatchCount'); //get the mapping name displayed if the mappingId is set @@ -48,11 +47,6 @@ class CRM_Contribute_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } - if ($conflictRowCount) { - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Contribute_Import_Parser_Contribution'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - } - if ($mismatchCount) { $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Contribute_Import_Parser_Contribution'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); @@ -67,9 +61,7 @@ class CRM_Contribute_Import_Form_Preview extends CRM_Import_Form_Preview { 'totalRowCount', 'validRowCount', 'invalidRowCount', - 'conflictRowCount', 'downloadErrorRecordsUrl', - 'downloadConflictRecordsUrl', 'downloadMismatchRecordsUrl', ]; $this->setStatusUrl(); @@ -85,7 +77,6 @@ class CRM_Contribute_Import_Form_Preview extends CRM_Import_Form_Preview { public function postProcess() { $fileName = $this->controller->exportValue('DataSource', 'uploadFile'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $onDuplicate = $this->get('onDuplicate'); $mapperSoftCreditType = $this->get('mapperSoftCreditType'); @@ -152,8 +143,6 @@ class CRM_Contribute_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('errorFile', $errorFile); $urlParams = 'type=' . CRM_Import_Parser::ERROR . '&parser=CRM_Contribute_Import_Parser_Contribution'; $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Contribute_Import_Parser_Contribution'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Contribute_Import_Parser_Contribution'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } diff --git a/CRM/Contribute/Import/Form/Summary.php b/CRM/Contribute/Import/Form/Summary.php index 6714befabc..b1fc36d05c 100644 --- a/CRM/Contribute/Import/Form/Summary.php +++ b/CRM/Contribute/Import/Form/Summary.php @@ -45,7 +45,6 @@ class CRM_Contribute_Import_Form_Summary extends CRM_Import_Form_Summary { $this->set('downloadPledgePaymentErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } $validPledgePaymentRowCount = $this->get('validPledgePaymentRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $duplicateRowCount = $this->get('duplicateRowCount'); $onDuplicate = $this->get('onDuplicate'); $mismatchCount = $this->get('unMatchCount'); @@ -80,7 +79,7 @@ class CRM_Contribute_Import_Form_Summary extends CRM_Import_Form_Summary { /* only subtract dupes from successful import if we're skipping */ $this->set('validRowCount', $totalRowCount - $invalidRowCount - - $conflictRowCount - $duplicateRowCount - $mismatchCount - $invalidSoftCreditRowCount - $invalidPledgePaymentRowCount + $duplicateRowCount - $mismatchCount - $invalidSoftCreditRowCount - $invalidPledgePaymentRowCount ); } $this->assign('dupeActionString', $dupeActionString); @@ -91,8 +90,6 @@ class CRM_Contribute_Import_Form_Summary extends CRM_Import_Form_Summary { 'invalidRowCount', 'validSoftCreditRowCount', 'invalidSoftCreditRowCount', - 'conflictRowCount', - 'downloadConflictRecordsUrl', 'downloadErrorRecordsUrl', 'duplicateRowCount', 'downloadDuplicateRecordsUrl', diff --git a/CRM/Contribute/Import/Parser/Contribution.php b/CRM/Contribute/Import/Parser/Contribution.php index 3fe3493a49..4a639e2f5a 100644 --- a/CRM/Contribute/Import/Parser/Contribution.php +++ b/CRM/Contribute/Import/Parser/Contribution.php @@ -191,11 +191,10 @@ class CRM_Contribute_Import_Parser_Contribution extends CRM_Import_Parser { $this->_lineCount = $this->_validSoftCreditRowCount = $this->_validPledgePaymentRowCount = 0; $this->_invalidRowCount = $this->_validCount = $this->_invalidSoftCreditRowCount = $this->_invalidPledgePaymentRowCount = 0; - $this->_totalCount = $this->_conflictCount = 0; + $this->_totalCount = 0; $this->_errors = []; $this->_warnings = []; - $this->_conflicts = []; $this->_pledgePaymentErrors = []; $this->_softCreditErrors = []; if ($statusID) { @@ -317,16 +316,6 @@ class CRM_Contribute_Import_Parser_Contribution extends CRM_Import_Parser { $this->_softCreditErrors[] = $values; } - if ($returnCode == self::CONFLICT) { - $this->_conflictCount++; - $recordNumber = $this->_lineCount; - if ($this->_haveColumnHeader) { - $recordNumber--; - } - array_unshift($values, $recordNumber); - $this->_conflicts[] = $values; - } - if ($returnCode == self::DUPLICATE) { $this->_duplicateCount++; $recordNumber = $this->_lineCount; @@ -387,14 +376,6 @@ class CRM_Contribute_Import_Parser_Contribution extends CRM_Import_Parser { self::exportCSV($this->_softCreditErrorsFileName, $headers, $this->_softCreditErrors); } - if ($this->_conflictCount) { - $headers = array_merge([ - ts('Line Number'), - ts('Reason'), - ], $customHeaders); - $this->_conflictFileName = self::errorFileName(self::CONFLICT); - self::exportCSV($this->_conflictFileName, $headers, $this->_conflicts); - } if ($this->_duplicateCount) { $headers = array_merge([ ts('Line Number'), @@ -536,7 +517,6 @@ class CRM_Contribute_Import_Parser_Contribution extends CRM_Import_Parser { $store->set('validSoftCreditRowCount', $this->_validSoftCreditRowCount); $store->set('invalidPledgePaymentRowCount', $this->_invalidPledgePaymentRowCount); $store->set('validPledgePaymentRowCount', $this->_validPledgePaymentRowCount); - $store->set('conflictRowCount', $this->_conflictCount); switch ($this->_contactType) { case 'Individual': @@ -554,9 +534,6 @@ class CRM_Contribute_Import_Parser_Contribution extends CRM_Import_Parser { if ($this->_invalidRowCount) { $store->set('errorsFileName', $this->_errorFileName); } - if ($this->_conflictCount) { - $store->set('conflictsFileName', $this->_conflictFileName); - } if (isset($this->_rows) && !empty($this->_rows)) { $store->set('dataValues', $this->_rows); } diff --git a/CRM/Custom/Import/Form/Preview.php b/CRM/Custom/Import/Form/Preview.php index 75a51cfcb3..b917b928e1 100644 --- a/CRM/Custom/Import/Form/Preview.php +++ b/CRM/Custom/Import/Form/Preview.php @@ -18,7 +18,6 @@ class CRM_Custom_Import_Form_Preview extends CRM_Import_Form_Preview { $dataValues = $this->get('dataValues'); $mapper = $this->get('mapper'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $mismatchCount = $this->get('unMatchCount'); $entity = $this->get('_entity'); @@ -36,11 +35,6 @@ class CRM_Custom_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } - if ($conflictRowCount) { - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . $this->_importParserUrl; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - } - if ($mismatchCount) { $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . $this->_importParserUrl; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); @@ -53,9 +47,7 @@ class CRM_Custom_Import_Form_Preview extends CRM_Import_Form_Preview { 'totalRowCount', 'validRowCount', 'invalidRowCount', - 'conflictRowCount', 'downloadErrorRecordsUrl', - 'downloadConflictRecordsUrl', 'downloadMismatchRecordsUrl', ]; @@ -73,7 +65,6 @@ class CRM_Custom_Import_Form_Preview extends CRM_Import_Form_Preview { public function postProcess() { $fileName = $this->getSubmittedValue('uploadFile'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $onDuplicate = $this->get('onDuplicate'); $entity = $this->get('_entity'); @@ -128,8 +119,6 @@ class CRM_Custom_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('errorFile', $errorFile); $urlParams = 'type=' . CRM_Import_Parser::ERROR . $this->_importParserUrl; $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . $this->_importParserUrl; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . $this->_importParserUrl; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } diff --git a/CRM/Custom/Import/Parser/Api.php b/CRM/Custom/Import/Parser/Api.php index 5bfb22f238..042c910c02 100644 --- a/CRM/Custom/Import/Parser/Api.php +++ b/CRM/Custom/Import/Parser/Api.php @@ -395,11 +395,10 @@ class CRM_Custom_Import_Parser_Api extends CRM_Import_Parser { $this->_lineCount = $this->_warningCount = 0; $this->_invalidRowCount = $this->_validCount = 0; - $this->_totalCount = $this->_conflictCount = 0; + $this->_totalCount = 0; $this->_errors = []; $this->_warnings = []; - $this->_conflicts = []; $this->_fileSize = number_format(filesize($fileName) / 1024.0, 2); @@ -481,16 +480,6 @@ class CRM_Custom_Import_Parser_Api extends CRM_Import_Parser { $this->_errors[] = $values; } - if ($returnCode & self::CONFLICT) { - $this->_conflictCount++; - $recordNumber = $this->_lineCount; - if ($this->_haveColumnHeader) { - $recordNumber--; - } - array_unshift($values, $recordNumber); - $this->_conflicts[] = $values; - } - if ($returnCode & self::DUPLICATE) { $this->_duplicateCount++; $recordNumber = $this->_lineCount; @@ -530,14 +519,7 @@ class CRM_Custom_Import_Parser_Api extends CRM_Import_Parser { $this->_errorFileName = self::errorFileName(self::ERROR); CRM_Contact_Import_Parser_Contact::exportCSV($this->_errorFileName, $headers, $this->_errors); } - if ($this->_conflictCount) { - $headers = array_merge([ - ts('Line Number'), - ts('Reason'), - ], $customHeaders); - $this->_conflictFileName = self::errorFileName(self::CONFLICT); - CRM_Contact_Import_Parser_Contact::exportCSV($this->_conflictFileName, $headers, $this->_conflicts); - } + if ($this->_duplicateCount) { $headers = array_merge([ ts('Line Number'), @@ -612,7 +594,6 @@ class CRM_Custom_Import_Parser_Api extends CRM_Import_Parser { $store->set('totalRowCount', $this->_totalCount); $store->set('validRowCount', $this->_validCount); $store->set('invalidRowCount', $this->_invalidRowCount); - $store->set('conflictRowCount', $this->_conflictCount); switch ($this->_contactType) { case 'Individual': @@ -630,9 +611,7 @@ class CRM_Custom_Import_Parser_Api extends CRM_Import_Parser { if ($this->_invalidRowCount) { $store->set('errorsFileName', $this->_errorFileName); } - if ($this->_conflictCount) { - $store->set('conflictsFileName', $this->_conflictFileName); - } + if (isset($this->_rows) && !empty($this->_rows)) { $store->set('dataValues', $this->_rows); } diff --git a/CRM/Event/Import/Form/Preview.php b/CRM/Event/Import/Form/Preview.php index 3357c97f4f..79a76fde22 100644 --- a/CRM/Event/Import/Form/Preview.php +++ b/CRM/Event/Import/Form/Preview.php @@ -33,7 +33,6 @@ class CRM_Event_Import_Form_Preview extends CRM_Import_Form_Preview { $dataValues = $this->get('dataValues'); $mapper = $this->get('mapper'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $mismatchCount = $this->get('unMatchCount'); //get the mapping name displayed if the mappingId is set @@ -50,11 +49,6 @@ class CRM_Event_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } - if ($conflictRowCount) { - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Event_Import_Parser_Participant'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - } - if ($mismatchCount) { $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Event_Import_Parser_Participant'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); @@ -67,9 +61,7 @@ class CRM_Event_Import_Form_Preview extends CRM_Import_Form_Preview { 'totalRowCount', 'validRowCount', 'invalidRowCount', - 'conflictRowCount', 'downloadErrorRecordsUrl', - 'downloadConflictRecordsUrl', 'downloadMismatchRecordsUrl', ]; @@ -88,7 +80,6 @@ class CRM_Event_Import_Form_Preview extends CRM_Import_Form_Preview { $fileName = $this->controller->exportValue('DataSource', 'uploadFile'); $separator = $this->controller->exportValue('DataSource', 'fieldSeparator'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $onDuplicate = $this->get('onDuplicate'); $mapper = $this->controller->exportValue('MapField', 'mapper'); @@ -141,8 +132,6 @@ class CRM_Event_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('errorFile', $errorFile); $urlParams = 'type=' . CRM_Import_Parser::ERROR . '&parser=CRM_Event_Import_Parser_Participant'; $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Event_Import_Parser_Participant'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Event_Import_Parser_Participant'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } diff --git a/CRM/Event/Import/Form/Summary.php b/CRM/Event/Import/Form/Summary.php index a5b546e433..6184807db9 100644 --- a/CRM/Event/Import/Form/Summary.php +++ b/CRM/Event/Import/Form/Summary.php @@ -35,7 +35,6 @@ class CRM_Event_Import_Form_Summary extends CRM_Import_Form_Summary { $this->set('totalRowCount', $totalRowCount); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $duplicateRowCount = $this->get('duplicateRowCount'); $onDuplicate = $this->get('onDuplicate'); $mismatchCount = $this->get('unMatchCount'); @@ -70,7 +69,7 @@ class CRM_Event_Import_Form_Summary extends CRM_Import_Form_Summary { /* only subtract dupes from successful import if we're skipping */ $this->set('validRowCount', $totalRowCount - $invalidRowCount - - $conflictRowCount - $duplicateRowCount - $mismatchCount + $duplicateRowCount - $mismatchCount ); } $this->assign('dupeActionString', $dupeActionString); @@ -79,8 +78,6 @@ class CRM_Event_Import_Form_Summary extends CRM_Import_Form_Summary { 'totalRowCount', 'validRowCount', 'invalidRowCount', - 'conflictRowCount', - 'downloadConflictRecordsUrl', 'downloadErrorRecordsUrl', 'duplicateRowCount', 'downloadDuplicateRecordsUrl', diff --git a/CRM/Event/Import/Parser/Participant.php b/CRM/Event/Import/Parser/Participant.php index bd32fcf4d8..adbd4d43f8 100644 --- a/CRM/Event/Import/Parser/Participant.php +++ b/CRM/Event/Import/Parser/Participant.php @@ -759,11 +759,10 @@ class CRM_Event_Import_Parser_Participant extends CRM_Import_Parser { $this->_lineCount = 0; $this->_invalidRowCount = $this->_validCount = 0; - $this->_totalCount = $this->_conflictCount = 0; + $this->_totalCount = 0; $this->_errors = []; $this->_warnings = []; - $this->_conflicts = []; $this->_fileSize = number_format(filesize($fileName) / 1024.0, 2); @@ -838,16 +837,6 @@ class CRM_Event_Import_Parser_Participant extends CRM_Import_Parser { $this->_errors[] = $values; } - if ($returnCode & self::CONFLICT) { - $this->_conflictCount++; - $recordNumber = $this->_lineCount; - if ($this->_haveColumnHeader) { - $recordNumber--; - } - array_unshift($values, $recordNumber); - $this->_conflicts[] = $values; - } - if ($returnCode & self::DUPLICATE) { $this->_duplicateCount++; $recordNumber = $this->_lineCount; @@ -888,14 +877,6 @@ class CRM_Event_Import_Parser_Participant extends CRM_Import_Parser { $this->_errorFileName = self::errorFileName(self::ERROR); self::exportCSV($this->_errorFileName, $headers, $this->_errors); } - if ($this->_conflictCount) { - $headers = array_merge([ - ts('Line Number'), - ts('Reason'), - ], $customHeaders); - $this->_conflictFileName = self::errorFileName(self::CONFLICT); - self::exportCSV($this->_conflictFileName, $headers, $this->_conflicts); - } if ($this->_duplicateCount) { $headers = array_merge([ ts('Line Number'), @@ -977,7 +958,6 @@ class CRM_Event_Import_Parser_Participant extends CRM_Import_Parser { $store->set('totalRowCount', $this->_totalCount); $store->set('validRowCount', $this->_validCount); $store->set('invalidRowCount', $this->_invalidRowCount); - $store->set('conflictRowCount', $this->_conflictCount); switch ($this->_contactType) { case 'Individual': @@ -995,9 +975,6 @@ class CRM_Event_Import_Parser_Participant extends CRM_Import_Parser { if ($this->_invalidRowCount) { $store->set('errorsFileName', $this->_errorFileName); } - if ($this->_conflictCount) { - $store->set('conflictsFileName', $this->_conflictFileName); - } if (isset($this->_rows) && !empty($this->_rows)) { $store->set('dataValues', $this->_rows); } diff --git a/CRM/Import/Forms.php b/CRM/Import/Forms.php index d2b7d98ad8..3816383234 100644 --- a/CRM/Import/Forms.php +++ b/CRM/Import/Forms.php @@ -441,7 +441,7 @@ class CRM_Import_Forms extends CRM_Core_Form { * @return array|int * One or more of the statues available - e.g * CRM_Import_Parser::VALID - * or [CRM_Import_Parser::ERROR, CRM_Import_Parser::CONFLICT] + * or [CRM_Import_Parser::ERROR, CRM_Import_Parser::VALID] * * @throws \CRM_Core_Exception * @throws \API_Exception diff --git a/CRM/Import/Parser.php b/CRM/Import/Parser.php index 3ba55c5f48..1880d33b9a 100644 --- a/CRM/Import/Parser.php +++ b/CRM/Import/Parser.php @@ -160,18 +160,6 @@ abstract class CRM_Import_Parser { */ protected $_errors; - /** - * Total number of conflict lines - * @var int - */ - protected $_conflictCount; - - /** - * Array of conflict lines - * @var array - */ - protected $_conflicts; - /** * Total number of duplicate (from database) lines * @var int @@ -260,13 +248,6 @@ abstract class CRM_Import_Parser { */ protected $_errorFileName; - /** - * Filename of conflict data - * - * @var string - */ - protected $_conflictFileName; - /** * Filename of duplicate data * @@ -502,10 +483,6 @@ abstract class CRM_Import_Parser { $fileName .= '.errors'; break; - case self::CONFLICT: - $fileName .= '.conflicts'; - break; - case self::DUPLICATE: $fileName .= '.duplicates'; break; @@ -538,10 +515,6 @@ abstract class CRM_Import_Parser { $fileName = 'Import_Errors.csv'; break; - case self::CONFLICT: - $fileName = 'Import_Conflicts.csv'; - break; - case self::DUPLICATE: $fileName = 'Import_Duplicates.csv'; break; diff --git a/CRM/Member/Import/Form/Preview.php b/CRM/Member/Import/Form/Preview.php index 91959809ad..4c43964b58 100644 --- a/CRM/Member/Import/Form/Preview.php +++ b/CRM/Member/Import/Form/Preview.php @@ -32,7 +32,6 @@ class CRM_Member_Import_Form_Preview extends CRM_Import_Form_Preview { $dataValues = $this->get('dataValues'); $mapper = $this->get('mapper'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $mismatchCount = $this->get('unMatchCount'); //get the mapping name displayed if the mappingId is set @@ -49,11 +48,6 @@ class CRM_Member_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } - if ($conflictRowCount) { - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Member_Import_Parser_Membership'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - } - if ($mismatchCount) { $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Member_Import_Parser_Membership'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); @@ -66,9 +60,7 @@ class CRM_Member_Import_Form_Preview extends CRM_Import_Form_Preview { 'totalRowCount', 'validRowCount', 'invalidRowCount', - 'conflictRowCount', 'downloadErrorRecordsUrl', - 'downloadConflictRecordsUrl', 'downloadMismatchRecordsUrl', ]; $this->setStatusUrl(); @@ -87,7 +79,6 @@ class CRM_Member_Import_Form_Preview extends CRM_Import_Form_Preview { public function postProcess() { $fileName = $this->getSubmittedValue('uploadFile'); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $onDuplicate = $this->get('onDuplicate'); $mapper = $this->controller->exportValue('MapField', 'mapper'); @@ -160,8 +151,6 @@ class CRM_Member_Import_Form_Preview extends CRM_Import_Form_Preview { $this->set('errorFile', $errorFile); $urlParams = 'type=' . CRM_Import_Parser::ERROR . '&parser=CRM_Member_Import_Parser_Membership'; $this->set('downloadErrorRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); - $urlParams = 'type=' . CRM_Import_Parser::CONFLICT . '&parser=CRM_Member_Import_Parser_Membership'; - $this->set('downloadConflictRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); $urlParams = 'type=' . CRM_Import_Parser::NO_MATCH . '&parser=CRM_Member_Import_Parser_Membership'; $this->set('downloadMismatchRecordsUrl', CRM_Utils_System::url('civicrm/export', $urlParams)); } diff --git a/CRM/Member/Import/Form/Summary.php b/CRM/Member/Import/Form/Summary.php index 890725426b..a21a567b6a 100644 --- a/CRM/Member/Import/Form/Summary.php +++ b/CRM/Member/Import/Form/Summary.php @@ -35,7 +35,6 @@ class CRM_Member_Import_Form_Summary extends CRM_Import_Form_Summary { $this->set('totalRowCount', $totalRowCount); $invalidRowCount = $this->get('invalidRowCount'); - $conflictRowCount = $this->get('conflictRowCount'); $duplicateRowCount = $this->get('duplicateRowCount'); $onDuplicate = $this->get('onDuplicate'); $mismatchCount = $this->get('unMatchCount'); @@ -70,7 +69,7 @@ class CRM_Member_Import_Form_Summary extends CRM_Import_Form_Summary { /* only subtract dupes from successful import if we're skipping */ $this->set('validRowCount', $totalRowCount - $invalidRowCount - - $conflictRowCount - $duplicateRowCount - $mismatchCount + $duplicateRowCount - $mismatchCount ); } $this->assign('dupeActionString', $dupeActionString); @@ -79,8 +78,6 @@ class CRM_Member_Import_Form_Summary extends CRM_Import_Form_Summary { 'totalRowCount', 'validRowCount', 'invalidRowCount', - 'conflictRowCount', - 'downloadConflictRecordsUrl', 'downloadErrorRecordsUrl', 'duplicateRowCount', 'downloadDuplicateRecordsUrl', diff --git a/CRM/Member/Import/Parser/Membership.php b/CRM/Member/Import/Parser/Membership.php index 357339d5e5..0e643ceb51 100644 --- a/CRM/Member/Import/Parser/Membership.php +++ b/CRM/Member/Import/Parser/Membership.php @@ -133,11 +133,10 @@ class CRM_Member_Import_Parser_Membership extends CRM_Import_Parser { $this->_lineCount = 0; $this->_invalidRowCount = $this->_validCount = 0; - $this->_totalCount = $this->_conflictCount = 0; + $this->_totalCount = 0; $this->_errors = []; $this->_warnings = []; - $this->_conflicts = []; $this->_fileSize = number_format(filesize($fileName) / 1024.0, 2); @@ -214,13 +213,6 @@ class CRM_Member_Import_Parser_Membership extends CRM_Import_Parser { $this->_errors[] = $values; } - if ($returnCode & self::CONFLICT) { - $this->_conflictCount++; - $recordNumber = $this->_lineCount; - array_unshift($values, $recordNumber); - $this->_conflicts[] = $values; - } - if ($returnCode & self::DUPLICATE) { $this->_duplicateCount++; $recordNumber = $this->_lineCount; @@ -258,14 +250,6 @@ class CRM_Member_Import_Parser_Membership extends CRM_Import_Parser { self::exportCSV($this->_errorFileName, $headers, $this->_errors); } - if ($this->_conflictCount) { - $headers = array_merge([ - ts('Line Number'), - ts('Reason'), - ], $customHeaders); - $this->_conflictFileName = self::errorFileName(self::CONFLICT); - self::exportCSV($this->_conflictFileName, $headers, $this->_conflicts); - } if ($this->_duplicateCount) { $headers = array_merge([ ts('Line Number'), @@ -367,7 +351,6 @@ class CRM_Member_Import_Parser_Membership extends CRM_Import_Parser { $store->set('totalRowCount', $this->_totalCount); $store->set('validRowCount', $this->_validCount); $store->set('invalidRowCount', $this->_invalidRowCount); - $store->set('conflictRowCount', $this->_conflictCount); switch ($this->_contactType) { case 'Individual': @@ -385,9 +368,6 @@ class CRM_Member_Import_Parser_Membership extends CRM_Import_Parser { if ($this->_invalidRowCount) { $store->set('errorsFileName', $this->_errorFileName); } - if ($this->_conflictCount) { - $store->set('conflictsFileName', $this->_conflictFileName); - } if (isset($this->_rows) && !empty($this->_rows)) { $store->set('dataValues', $this->_rows); } diff --git a/templates/CRM/Activity/Import/Form/Preview.tpl b/templates/CRM/Activity/Import/Form/Preview.tpl index 111dddc644..33b4be0009 100644 --- a/templates/CRM/Activity/Import/Form/Preview.tpl +++ b/templates/CRM/Activity/Import/Form/Preview.tpl @@ -25,13 +25,6 @@

{/if} - {if $conflictRowCount} -

- {ts 1=$conflictRowCount 2=$downloadConflictRecordsUrl}CiviCRM has detected %1 records with conflicting transaction ids within this data file. If you continue, these records will be skipped. OR, you can download a file with just these problem records - Download Conflicts. Then correct them in the original import file, cancel this import and begin again at step 1.{/ts} -

- {/if} - -

{ts}Click 'Import Now' if you are ready to proceed.{/ts}

{include file="CRM/common/formButtons.tpl" location="top"}
@@ -54,17 +47,6 @@ {/if} - {if $conflictRowCount} - {ts}Conflicting Rows{/ts} - {$conflictRowCount} - {ts}Rows with conflicting transaction ids within this file. These rows will be skipped (not imported).{/ts} - {if $conflictRowCount} -

{ts}Download Conflicts{/ts}

- {/if} - - - {/if} - {ts}Valid Rows{/ts} {$validRowCount} {ts}Total rows to be imported.{/ts} diff --git a/templates/CRM/Activity/Import/Form/Summary.tpl b/templates/CRM/Activity/Import/Form/Summary.tpl index 6f054ee726..09388501e8 100644 --- a/templates/CRM/Activity/Import/Form/Summary.tpl +++ b/templates/CRM/Activity/Import/Form/Summary.tpl @@ -37,15 +37,6 @@

{/if} - {if $conflictRowCount} -

- {ts count=$conflictRowCount plural='CiviCRM has detected %count records with conflicting transaction IDs within this data file or relative to existing activity records. These records have not been imported.'}CiviCRM has detected one record with conflicting transaction ID within this data file or relative to existing activity records. This record have not been imported.{/ts} -

-

- {ts 1=$downloadConflictRecordsUrl}You can Download Conflicts. You may then review these records to determine if they are actually conflicts, and correct the transaction IDs for those that are not.{/ts} -

- {/if} - {if $duplicateRowCount}

{ts count=$duplicateRowCount plural='CiviCRM has detected %count records which are duplicates of existing CiviCRM activity records.'}CiviCRM has detected one record which is a duplicate of existing CiviCRM activity record.{/ts} {$dupeActionString} @@ -85,17 +76,6 @@ {/if} - {if $conflictRowCount} - {ts}Conflicting Rows (skipped){/ts} - {$conflictRowCount} - {ts}Rows with conflicting transaction IDs (NOT imported).{/ts} - {if $conflictRowCount} -

{ts}Download Conflicts{/ts}

- {/if} - - - {/if} - {if $duplicateRowCount} {ts}Duplicate Rows{/ts} {$duplicateRowCount} diff --git a/templates/CRM/Contact/Import/Form/Preview.tpl b/templates/CRM/Contact/Import/Form/Preview.tpl index 93bea4cec1..1dbbbb9830 100644 --- a/templates/CRM/Contact/Import/Form/Preview.tpl +++ b/templates/CRM/Contact/Import/Form/Preview.tpl @@ -24,12 +24,6 @@

{/if} - {if $conflictRowCount} -

- {ts 1=$conflictRowCount 2=$downloadConflictRecordsUrl}CiviCRM has detected %1 records with conflicting email addresses within this data file. If you continue, these records will be skipped. OR, you can download a file with just these problem records - Download Conflicts. Then correct them in the original import file, cancel this import and begin again at step 1.{/ts} -

- {/if} -

{ts}Click 'Import Now' if you are ready to proceed.{/ts}

{include file="CRM/common/formButtons.tpl" location="top"}
diff --git a/templates/CRM/Contact/Import/Form/Summary.tpl b/templates/CRM/Contact/Import/Form/Summary.tpl index 1a4a9baad8..39c022d0a0 100644 --- a/templates/CRM/Contact/Import/Form/Summary.tpl +++ b/templates/CRM/Contact/Import/Form/Summary.tpl @@ -37,15 +37,6 @@

{/if} - {if $conflictRowCount} -

- {ts count=$conflictRowCount plural='CiviCRM has detected %count records with conflicting email addresses within this data file or relative to existing contact records. These records have not been imported.'}CiviCRM has detected one record with conflicting email addresses within this data file or relative to existing contact records. This record has not been imported.{/ts} {ts}CiviCRM does not allow multiple contact records to have the same primary email address.{/ts} -

-

- {ts 1=$downloadConflictRecordsUrl}You can Download Conflicts. You may then review these records to determine if they are actually conflicts, and correct the email addresses for those that are not.{/ts} -

- {/if} - {if $duplicateRowCount}

{ts count=$duplicateRowCount plural='CiviCRM has detected %count records which are duplicates of existing CiviCRM contact records.'}CiviCRM has detected one record which is a duplicate of existing CiviCRM contact record.{/ts} {$dupeActionString} @@ -92,17 +83,6 @@ {/if} - {if $conflictRowCount} - {ts}Conflicting Rows (skipped){/ts} - {$conflictRowCount} - {ts}Rows with conflicting email addresses (NOT imported).{/ts} - {if $conflictRowCount} -

- {/if} - - - {/if} - {if $duplicateRowCount && $dupeError} {ts}Duplicate Rows{/ts} {$duplicateRowCount} diff --git a/templates/CRM/Contribute/Import/Form/Preview.tpl b/templates/CRM/Contribute/Import/Form/Preview.tpl index 2f1a625acd..bf4557bcf0 100644 --- a/templates/CRM/Contribute/Import/Form/Preview.tpl +++ b/templates/CRM/Contribute/Import/Form/Preview.tpl @@ -24,13 +24,6 @@

{/if} - {if $conflictRowCount} -

- {ts 1=$conflictRowCount 2=$downloadConflictRecordsUrl}CiviCRM has detected %1 records with conflicting transaction ids within this data file. If you continue, these records will be skipped. You can download a file with just these problem records: Download Conflicts. If you wish, you can then correct them in the original import file, cancel this import and begin again at step 1.{/ts} -

- {/if} - -

{ts}Click 'Import Now' if you are ready to proceed.{/ts}

{include file="CRM/common/formButtons.tpl" location="top"}
@@ -53,17 +46,6 @@ {/if} - {if $conflictRowCount} - {ts}Conflicting Rows{/ts} - {$conflictRowCount} - {ts}Rows with conflicting transaction ids within this file. These rows will be skipped (not imported).{/ts} - {if $conflictRowCount} -

{ts}Download Conflicts{/ts}

- {/if} - - - {/if} - {ts}Valid Rows{/ts} {$validRowCount} {ts}Total rows to be imported.{/ts} diff --git a/templates/CRM/Contribute/Import/Form/Summary.tpl b/templates/CRM/Contribute/Import/Form/Summary.tpl index ae7bc83cb7..7d0c860060 100644 --- a/templates/CRM/Contribute/Import/Form/Summary.tpl +++ b/templates/CRM/Contribute/Import/Form/Summary.tpl @@ -36,15 +36,6 @@

{/if} - {if $conflictRowCount} -

- {ts count=$conflictRowCount plural='CiviCRM has detected %count records with conflicting transaction IDs within this data file or relative to existing contribution records. These records have not been imported.'}CiviCRM has detected one record with conflicting transaction ID within this data file or relative to existing contribution records. This record has not been imported.{/ts} -

-

- {ts 1=$downloadConflictRecordsUrl}You can Download Conflicts. You may then review these records to determine if they are actually conflicts, and correct the transaction IDs for those that are not.{/ts} -

- {/if} - {if $duplicateRowCount}

{ts count=$duplicateRowCount plural='CiviCRM has detected %count records which are duplicates of existing CiviCRM contribution records.'}CiviCRM has detected one record which is a duplicate of existing CiviCRM contribution record.{/ts} {$dupeActionString} @@ -119,17 +110,6 @@ {/if} - {if $conflictRowCount} - {ts}Conflicting Rows (skipped){/ts} - {$conflictRowCount} - {ts}Rows with conflicting transaction IDs (NOT imported).{/ts} - {if $conflictRowCount} -

{ts}Download Conflicts{/ts}

- {/if} - - - {/if} - {if $duplicateRowCount} {ts}Duplicate Rows{/ts} {$duplicateRowCount} diff --git a/templates/CRM/Event/Import/Form/Preview.tpl b/templates/CRM/Event/Import/Form/Preview.tpl index 62220cc985..e7266aac90 100644 --- a/templates/CRM/Event/Import/Form/Preview.tpl +++ b/templates/CRM/Event/Import/Form/Preview.tpl @@ -25,13 +25,6 @@

{/if} - {if $conflictRowCount} -

- {ts 1=$conflictRowCount 2=$downloadConflictRecordsUrl}CiviCRM has detected %1 records with conflicting participant IDs within this data file. If you continue, these records will be skipped. OR, you can download a file with just these problem records - Download Conflicts. Then correct them in the original import file, cancel this import and begin again at step 1.{/ts} -

- {/if} - -

{ts}Click 'Import Now' if you are ready to proceed.{/ts}

@@ -56,17 +49,6 @@ {/if} - {if $conflictRowCount} - {ts}Conflicting Rows{/ts} - {$conflictRowCount} - {ts}Rows with conflicting participant IDs within this file. These rows will be skipped (not imported).{/ts} - {if $conflictRowCount} -

{ts}Download Conflicts{/ts}

- {/if} - - - {/if} - {ts}Valid Rows{/ts} {$validRowCount} {ts}Total rows to be imported.{/ts} diff --git a/templates/CRM/Event/Import/Form/Summary.tpl b/templates/CRM/Event/Import/Form/Summary.tpl index 5d600cdf40..b27daf6ad0 100644 --- a/templates/CRM/Event/Import/Form/Summary.tpl +++ b/templates/CRM/Event/Import/Form/Summary.tpl @@ -38,15 +38,6 @@

{/if} - {if $conflictRowCount} -

- {ts count=$conflictRowCount plural='CiviCRM has detected %count records with conflicting participant IDs within this data file or relative to existing participant records. These records have not been imported.'}CiviCRM has detected one record with conflicting participant ID within this data file or relative to existing participant records. This record has not been imported.{/ts} -

-

- {ts 1=$downloadConflictRecordsUrl}You can Download Conflicts. You may then review these records to determine if they are actually conflicts, and correct the participant IDs for those that are not.{/ts} -

- {/if} - {if $duplicateRowCount}

{ts count=$duplicateRowCount plural='CiviCRM has detected %count records which are duplicates of existing CiviCRM participant records.'}CiviCRM has detected one record which is a duplicate of existing CiviCRM participant record.{/ts} {$dupeActionString} @@ -89,17 +80,6 @@ {/if} - {if $conflictRowCount} - {ts}Conflicting Rows (skipped){/ts} - {$conflictRowCount} - {ts}Rows with conflicting participant IDs (NOT imported).{/ts} - {if $conflictRowCount} -

{ts}Download Conflicts{/ts}

- {/if} - - - {/if} - {if $duplicateRowCount} {ts}Duplicate Rows{/ts} {$duplicateRowCount} diff --git a/templates/CRM/Member/Import/Form/Preview.tpl b/templates/CRM/Member/Import/Form/Preview.tpl index 390b7e2250..809193341a 100644 --- a/templates/CRM/Member/Import/Form/Preview.tpl +++ b/templates/CRM/Member/Import/Form/Preview.tpl @@ -25,13 +25,6 @@

{/if} - {if $conflictRowCount} -

- {ts 1=$conflictRowCount 2=$downloadConflictRecordsUrl}CiviCRM has detected %1 records with conflicting transaction ids within this data file. If you continue, these records will be skipped. OR, you can download a file with just these problem records - Download Conflicts. Then correct them in the original import file, cancel this import and begin again at step 1.{/ts} -

- {/if} - -

{ts}Click 'Import Now' if you are ready to proceed.{/ts}

{include file="CRM/common/formButtons.tpl" location="top"}
@@ -54,17 +47,6 @@ {/if} - {if $conflictRowCount} - {ts}Conflicting Rows{/ts} - {$conflictRowCount} - {ts}Rows with conflicting transaction ids within this file. These rows will be skipped (not imported).{/ts} - {if $conflictRowCount} - - {/if} - - - {/if} - {ts}Valid Rows{/ts} {$validRowCount} {ts}Total rows to be imported.{/ts} diff --git a/templates/CRM/Member/Import/Form/Summary.tpl b/templates/CRM/Member/Import/Form/Summary.tpl index 70fd4ccdc1..f2ea3263f1 100644 --- a/templates/CRM/Member/Import/Form/Summary.tpl +++ b/templates/CRM/Member/Import/Form/Summary.tpl @@ -37,15 +37,6 @@

{/if} - {if $conflictRowCount} -

- {ts count=$conflictRowCount plural='CiviCRM has detected %count records with conflicting transaction IDs within this data file or relative to existing membership records. These records have not been imported.'}CiviCRM has detected one record with conflicting transaction ID within this data file or relative to existing membership records. This record has not been imported.{/ts} -

-

- {ts 1=$downloadConflictRecordsUrl}You can Download Conflicts. You may then review these records to determine if they are actually conflicts, and correct the transaction IDs for those that are not.{/ts} -

- {/if} - {if $duplicateRowCount}

{ts count=$duplicateRowCount plural='CiviCRM has detected %count records which are duplicates of existing CiviCRM membership records.'}CiviCRM has detected one record which is a duplicate of existing CiviCRM membership record.{/ts} {$dupeActionString} @@ -85,17 +76,6 @@ {/if} - {if $conflictRowCount} - {ts}Conflicting Rows (skipped){/ts} - {$conflictRowCount} - {ts}Rows with conflicting transaction IDs (NOT imported).{/ts} - {if $conflictRowCount} -

{ts}Download Conflicts{/ts}

- {/if} - - - {/if} - {if $duplicateRowCount} {ts}Duplicate Rows{/ts} {$duplicateRowCount} -- 2.25.1