From d81be90bcf94f5b73913cdcc701256cc53c99b68 Mon Sep 17 00:00:00 2001 From: eileen Date: Fri, 21 Jun 2019 18:19:21 -0400 Subject: [PATCH] [REF] do not pass by reference to store & create functions After checking the code these are unchanged & not using pass-by-reference unecessarily is better practice --- CRM/Core/BAO/CustomValueTable.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CRM/Core/BAO/CustomValueTable.php b/CRM/Core/BAO/CustomValueTable.php index 759e83a719..ff9e634108 100644 --- a/CRM/Core/BAO/CustomValueTable.php +++ b/CRM/Core/BAO/CustomValueTable.php @@ -39,7 +39,7 @@ class CRM_Core_BAO_CustomValueTable { * * @throws Exception */ - public static function create(&$customParams) { + public static function create($customParams) { if (empty($customParams) || !is_array($customParams) ) { @@ -338,7 +338,7 @@ class CRM_Core_BAO_CustomValueTable { * @param $entityTable * @param int $entityID */ - public static function store(&$params, $entityTable, $entityID) { + public static function store($params, $entityTable, $entityID) { $cvParams = []; foreach ($params as $fieldID => $param) { foreach ($param as $index => $customValue) { -- 2.25.1