From d81916a2c1e4ad513e01ba36d8af5bbc2a3b0529 Mon Sep 17 00:00:00 2001 From: eileen Date: Mon, 7 Oct 2019 06:57:29 +0200 Subject: [PATCH] [REF] don't handle non-array, pass by reference This is only called from one place & it is definitely coming in as an array & using the return values. --- CRM/Contact/Form/Search/Advanced.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/CRM/Contact/Form/Search/Advanced.php b/CRM/Contact/Form/Search/Advanced.php index 0fcb3e7364..a3f46e68de 100644 --- a/CRM/Contact/Form/Search/Advanced.php +++ b/CRM/Contact/Form/Search/Advanced.php @@ -386,10 +386,7 @@ class CRM_Contact_Form_Search_Advanced extends CRM_Contact_Form_Search { * * @return array */ - public function normalizeDefaultValues(&$defaults) { - if (!is_array($defaults)) { - $defaults = array(); - } + public function normalizeDefaultValues($defaults) { $this->loadDefaultCountryBasedOnState($defaults); if ($this->_ssID && empty($_POST)) { $defaults = array_merge($defaults, CRM_Contact_BAO_SavedSearch::getFormValues($this->_ssID)); -- 2.25.1