From d7b226af900687b6e59e098329fbedf6e0d861a7 Mon Sep 17 00:00:00 2001 From: Mathieu Lutfy Date: Wed, 29 Mar 2017 18:10:56 -0400 Subject: [PATCH] CRM-20336: Failed contributions should be set as failed, not left as pending (cleanup) --- CRM/Contribute/BAO/Contribution.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index 846b6314cc..2e3404c360 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -1055,12 +1055,9 @@ LEFT JOIN civicrm_line_item i ON ( i.contribution_id = c.id AND i.entity_table )); // CRM-20336 Make sure that the contribution status is Failed, not Pending. - $contributionStatus = CRM_Contribute_PseudoConstant::contributionStatus(NULL, 'name'); - $failed = array_search('Failed', $contributionStatus); - civicrm_api3('contribution', 'create', array( 'id' => $contributionID, - 'contribution_status_id' => $failed, + 'contribution_status_id' => 'Failed', )); } -- 2.25.1