From d6e403420b11ad49d3f8128bd892109a28080ef7 Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Sat, 4 Jan 2020 22:29:20 -0500
Subject: [PATCH] GUI - simplify menus; only add items from palette

---
 ext/afform/gui/ang/afGuiEditor.css            |  9 ---------
 ext/afform/gui/ang/afGuiEditor.js             | 19 -------------------
 .../gui/ang/afGuiEditor/canvas-menu.html      |  8 --------
 .../gui/ang/afGuiEditor/container-menu.html   |  5 -----
 ext/afform/gui/ang/afGuiEditor/container.html | 12 ++----------
 5 files changed, 2 insertions(+), 51 deletions(-)
 delete mode 100644 ext/afform/gui/ang/afGuiEditor/canvas-menu.html

diff --git a/ext/afform/gui/ang/afGuiEditor.css b/ext/afform/gui/ang/afGuiEditor.css
index 7848835d6a..139f45a3bb 100644
--- a/ext/afform/gui/ang/afGuiEditor.css
+++ b/ext/afform/gui/ang/afGuiEditor.css
@@ -124,9 +124,6 @@
   opacity: 1;
   transition: opacity .2s;
 }
-#afGuiEditor-canvas-body > div > .af-gui-bar {
-  top: -5px;
-}
 
 #afGuiEditor .af-gui-bar .btn.active {
   background-color: #b3b3b3;
@@ -221,12 +218,6 @@
   left: 4px;
   top: 5px;
 }
-#afGuiEditor #afGuiEditor-canvas .af-gui-add-canvas-button {
-  border: 2px dashed #0071bd;
-  color: #0071bd;
-  padding-top: 2px;
-  padding-bottom: 2px;
-}
 #afGuiEditor .af-gui-add-element-button span {
   display: inline-block;
   width: 18px;
diff --git a/ext/afform/gui/ang/afGuiEditor.js b/ext/afform/gui/ang/afGuiEditor.js
index 37336c2810..43fae53d29 100644
--- a/ext/afform/gui/ang/afGuiEditor.js
+++ b/ext/afform/gui/ang/afGuiEditor.js
@@ -444,25 +444,6 @@
         $scope.editor = ctrls[0];
         $scope.parentContainer = ctrls[1];
 
-        $scope.addElement = function(type, props) {
-          var classes = type.split('.');
-          var element = _.defaults({
-            '#tag': classes.shift(),
-            'class': classes.join(' '),
-          }, props);
-          if (_.includes(classes, 'af-container')) {
-            element['#children'] = [];
-          } else if (_.intersection(classes, ['af-text', 'af-button']).length) {
-            element['#children'] = [{'#text': ts('Enter text')}];
-          }
-          var children = $scope.getSetChildren();
-          if (children) {
-            // Add it to the top, underneath the fieldset legend if present
-            var pos = children.length && children[0]['#tag'] === 'legend' ? 1 : 0;
-            children.splice(pos, 0, element);
-          }
-        };
-
         $scope.isSelectedFieldset = function(entityName) {
           return entityName === $scope.editor.getSelectedEntityName();
         };
diff --git a/ext/afform/gui/ang/afGuiEditor/canvas-menu.html b/ext/afform/gui/ang/afGuiEditor/canvas-menu.html
deleted file mode 100644
index 9d1932c7da..0000000000
--- a/ext/afform/gui/ang/afGuiEditor/canvas-menu.html
+++ /dev/null
@@ -1,8 +0,0 @@
-<li><a href ng-click="addElement('div.af-container')">{{ ts('Add container') }}</a></li>
-<li><a href ng-click="addElement('p.af-text')">{{ ts('Add text box') }}</a></li>
-<li><a href ng-click="addElement('div.af-markup', {'#markup': false})">{{ ts('Add rich content') }}</a></li>
-<li><a href ng-click="addElement('button.af-button.btn-primary', {'crm-icon': 'fa-check', 'ng-click': 'afform.submit()'})">{{ ts('Add button') }}</a></li>
-<li role="separator" class="divider"></li>
-<li ng-repeat="entity in editor.scope.entities">
-  <a href ng-click="addElement('fieldset.af-container', {'af-fieldset': entity.name})">{{ ts('Fieldset for %1', {1: entity.label}) }}</a>
-</li>
diff --git a/ext/afform/gui/ang/afGuiEditor/container-menu.html b/ext/afform/gui/ang/afGuiEditor/container-menu.html
index 44d25ba239..9dcf83487a 100644
--- a/ext/afform/gui/ang/afGuiEditor/container-menu.html
+++ b/ext/afform/gui/ang/afGuiEditor/container-menu.html
@@ -1,8 +1,3 @@
-<li><a href ng-click="addElement('div.af-container')">{{ ts('Add container') }}</a></li>
-<li><a href ng-click="addElement('p.af-text')">{{ ts('Add text box') }}</a></li>
-<li><a href ng-click="addElement('div.af-markup', {'#markup': false})">{{ ts('Add rich content') }}</a></li>
-<li><a href ng-click="addElement('button.af-button.btn-primary', {'crm-icon': 'fa-check', 'ng-click': 'afform.submit()'})">{{ ts('Add button') }}</a></li>
-<li role="separator" class="divider"></li>
 <li ng-if="!node['af-fieldset'] && !block.layout"><a href ng-click="saveBlock()">{{ ts('Save as block') }}</a></li>
 <li ng-if="!node['af-fieldset'] && !block.layout" role="separator" class="divider"></li>
 <li ng-if="tags[node['#tag']]">
diff --git a/ext/afform/gui/ang/afGuiEditor/container.html b/ext/afform/gui/ang/afGuiEditor/container.html
index 31c30b4715..450b6501d7 100644
--- a/ext/afform/gui/ang/afGuiEditor/container.html
+++ b/ext/afform/gui/ang/afGuiEditor/container.html
@@ -8,20 +8,12 @@
       <option ng-value="option.id" ng-repeat="option in block.options track by option.id">{{ option.text }}</option>
     </select>
     <button type="button" class="btn btn-default btn-xs" ng-if="block && !block.layout" ng-click="saveBlock()">{{ ts('Save...') }}</button>
-    <button type="button" class="btn btn-default btn-xs dropdown-toggle af-gui-add-element-button pull-right" data-toggle="dropdown" title="{{ ts('Add Element') }}">
-      <span><i class="crm-i fa-plus"></i></span>
+    <button type="button" class="btn btn-default btn-xs dropdown-toggle af-gui-add-element-button pull-right" data-toggle="dropdown" title="{{ ts('Configure') }}">
+      <span><i class="crm-i fa-gear"></i></span>
     </button>
     <ul class="dropdown-menu dropdown-menu-right" ng-if="menu.open" ng-include="'~/afGuiEditor/container-menu.html'"></ul>
   </div>
 </div>
-<div class="af-gui-bar" ng-if="node['#tag'] === 'af-form'" >
-  <div class="form-inline pull-right" af-gui-menu>
-    <button type="button" class="btn  btn-default btn-sm dropdown-toggle af-gui-add-canvas-button" data-toggle="dropdown" title="{{ ts('Add Element') }}">
-      <span>Add <i class="crm-i fa-plus"></i></span>
-    </button>
-    <ul class="dropdown-menu" ng-if="menu.open" ng-include="'~/afGuiEditor/canvas-menu.html'"></ul>
-  </div>
-</div>
 <div ui-sortable="{handle: '.af-gui-bar', connectWith: '[ui-sortable]', cancel: 'input,textarea,button,select,option,a,.dropdown-menu', placeholder: 'af-gui-dropzone', containment: '#afGuiEditor-canvas-body'}" ui-sortable-update="editor.onDrop" ng-model="getSetChildren" ng-model-options="{getterSetter: true}" class="af-gui-layout {{ getLayout() }}">
   <div ng-repeat="item in getSetChildren()" >
     <div ng-switch="container.getNodeType(item)">
-- 
2.25.1