From d6cbbf22694d76a85b1e72dbe7601d7da8fcff14 Mon Sep 17 00:00:00 2001 From: colemanw Date: Fri, 29 Dec 2023 14:24:32 -0600 Subject: [PATCH] SearchKit - Fix wrong column being removed from displays Fixes recent regression from 4099cd6 causing the wrong column to be removed from a display. To reproduce: Create a search display, go back to the main search criteria and delete a column, then tab back to the display. The deleted column should have been removed but instead the wrong one is still there. --- .../ang/crmSearchAdmin/crmSearchAdminDisplay.component.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/search_kit/ang/crmSearchAdmin/crmSearchAdminDisplay.component.js b/ext/search_kit/ang/crmSearchAdmin/crmSearchAdminDisplay.component.js index 7d1b856fb2..2e92948a52 100644 --- a/ext/search_kit/ang/crmSearchAdmin/crmSearchAdminDisplay.component.js +++ b/ext/search_kit/ang/crmSearchAdmin/crmSearchAdminDisplay.component.js @@ -319,8 +319,8 @@ let selectAliases = ctrl.savedSearch.api_params.select.map(selectExpr => selectToKey(selectExpr)); // Delete any column that is no longer in the activeColumns.reverse().forEach((key, index) => { - if (key && !_.includes(selectAliases, key)) { - ctrl.display.settings.columns.splice(index, 1); + if (key && !selectAliases.includes(key)) { + ctrl.removeCol(activeColumns.length - 1 - index); } }); } -- 2.25.1