From d34e92cc7af8ef1ae847cd6932c2c8e9ec139eb8 Mon Sep 17 00:00:00 2001
From: eileen <emcnaughton@wikimedia.org>
Date: Tue, 9 Jul 2019 19:08:35 +1200
Subject: [PATCH] Add unit test for saveFieldMapping

---
 CRM/Core/BAO/Mapping.php                   |   2 +
 tests/phpunit/CRM/Core/BAO/MappingTest.php | 129 ++++++++++++++++++++-
 2 files changed, 130 insertions(+), 1 deletion(-)

diff --git a/CRM/Core/BAO/Mapping.php b/CRM/Core/BAO/Mapping.php
index 6e44b09388..768b997f97 100644
--- a/CRM/Core/BAO/Mapping.php
+++ b/CRM/Core/BAO/Mapping.php
@@ -1222,6 +1222,8 @@ class CRM_Core_BAO_Mapping extends CRM_Core_DAO_Mapping {
     foreach ($params['mapper'] as $key => $value) {
       $colCnt = 0;
       foreach ($value as $k => $v) {
+        $locationTypeid = NULL;
+        $phoneTypeid = NULL;
 
         if (!empty($v['1'])) {
           $saveMappingFields = new CRM_Core_DAO_MappingField();
diff --git a/tests/phpunit/CRM/Core/BAO/MappingTest.php b/tests/phpunit/CRM/Core/BAO/MappingTest.php
index 8bc7a2b16d..0e9ba4b7d1 100644
--- a/tests/phpunit/CRM/Core/BAO/MappingTest.php
+++ b/tests/phpunit/CRM/Core/BAO/MappingTest.php
@@ -12,7 +12,134 @@ class CRM_Core_BAO_MappingTest extends CiviUnitTestCase {
    */
   public function testSaveMappingFields() {
     $mapping = $this->callAPISuccess('Mapping', 'create', ['name' => 'teest']);
-    CRM_Core_BAO_Mapping::saveMappingFields([], $mapping['id']);
+    $params = [
+      'qfKey' => '8d3bae0f77b62314516c1253176a1c1a_6756',
+      'entryURL' => 'http://dmaster.local/civicrm/contribute/search?reset=1',
+      'saveMappingName' => 'test',
+      'saveMappingDesc' => '',
+      'saveMapping' => '1',
+      'mapper' => [
+        1 =>
+          [
+            ['Individual', '10_b_a', 'id'],
+            ['Individual', 'city', ' '],
+            ['Individual', 'contact_sub_type'],
+            ['Student', 'custom_27'],
+            ['Individual', 'current_employer'],
+            ['Individual', 'phone', '1', '2'],
+            ['Individual', 'postal_code', '2'],
+            ['Individual', 'im', '1', '1'],
+            ['Individual', 'url'],
+            ['Individual', '1_b_a', 'phone', '5', '1'],
+          ],
+      ],
+    ];
+    CRM_Core_BAO_Mapping::saveMappingFields($params, $mapping['id']);
+    $expected = [
+      1 =>
+        [
+          'id' => '1',
+          'mapping_id' => '1',
+          'name' => 'id',
+          'contact_type' => 'Individual',
+          'column_number' => '0',
+          'relationship_type_id' => '10',
+          'relationship_direction' => 'b_a',
+          'grouping' => '1',
+        ],
+      2 =>
+        [
+          'id' => '2',
+          'mapping_id' => '1',
+          'name' => 'city',
+          'contact_type' => 'Individual',
+          'column_number' => '1',
+          'grouping' => '1',
+        ],
+      3 =>
+        [
+          'id' => '3',
+          'mapping_id' => '1',
+          'name' => 'contact_sub_type',
+          'contact_type' => 'Individual',
+          'column_number' => '2',
+          'grouping' => '1',
+        ],
+      4 =>
+        [
+          'id' => '4',
+          'mapping_id' => '1',
+          'name' => 'custom_27',
+          'contact_type' => 'Student',
+          'column_number' => '3',
+          'grouping' => '1',
+        ],
+      5 =>
+        [
+          'id' => '5',
+          'mapping_id' => '1',
+          'name' => 'current_employer',
+          'contact_type' => 'Individual',
+          'column_number' => '4',
+          'grouping' => '1',
+        ],
+      6 =>
+        [
+          'id' => '6',
+          'mapping_id' => '1',
+          'name' => 'phone',
+          'contact_type' => 'Individual',
+          'column_number' => '5',
+          'location_type_id' => '1',
+          'phone_type_id' => '2',
+          'grouping' => '1',
+        ],
+      7 =>
+        [
+          'id' => '7',
+          'mapping_id' => '1',
+          'name' => 'postal_code',
+          'contact_type' => 'Individual',
+          'column_number' => '6',
+          'location_type_id' => '2',
+          'grouping' => '1',
+        ],
+      8 =>
+        [
+          'id' => '8',
+          'mapping_id' => '1',
+          'name' => 'im',
+          'contact_type' => 'Individual',
+          'column_number' => '7',
+          'location_type_id' => '1',
+          'im_provider_id' => '1',
+          'grouping' => '1',
+        ],
+      9 =>
+        [
+          'id' => '9',
+          'mapping_id' => '1',
+          'name' => 'url',
+          'contact_type' => 'Individual',
+          'column_number' => '8',
+          'grouping' => '1',
+        ],
+      10 =>
+        [
+          'id' => '10',
+          'mapping_id' => '1',
+          'name' => 'phone',
+          'contact_type' => 'Individual',
+          'column_number' => '9',
+          'location_type_id' => '5',
+          'phone_type_id' => '1',
+          'relationship_type_id' => '1',
+          'relationship_direction' => 'b_a',
+          'grouping' => '1',
+        ],
+    ];
+    $saved = $this->callAPISuccess('MappingField', 'get', ['mapping_id' => $mapping['id']])['values'];
+    $this->assertEquals($expected, $saved);
   }
 
 }
-- 
2.25.1