From d27d37ad029952ae2b13314ceaa2047ba664cd63 Mon Sep 17 00:00:00 2001 From: larssandergreen Date: Wed, 23 Aug 2023 21:59:02 -0600 Subject: [PATCH] Fix checkbox JS regression for import data selection and email new template --- CRM/Import/Form/DataSource.php | 2 +- CRM/Mailing/BAO/Mailing.php | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/CRM/Import/Form/DataSource.php b/CRM/Import/Form/DataSource.php index 48c8046a3e..75149c026e 100644 --- a/CRM/Import/Form/DataSource.php +++ b/CRM/Import/Form/DataSource.php @@ -86,7 +86,7 @@ abstract class CRM_Import_Form_DataSource extends CRM_Import_Forms { $this->assign('urlPath', 'civicrm/import/datasource'); $this->assign('urlPathVar', 'snippet=4&user_job_id=' . $this->get('user_job_id')); if ($this->isImportDataUploaded()) { - $this->add('checkbox', 'use_existing_upload', ts('Use data already uploaded'), NULL, FALSE, [ + $this->add('checkbox', 'use_existing_upload', ts('Use data already uploaded'), [ 'onChange' => " CRM.$('.crm-import-datasource-form-block-dataSource').toggle(); CRM.$('#data-source-form-block').toggle()", diff --git a/CRM/Mailing/BAO/Mailing.php b/CRM/Mailing/BAO/Mailing.php index c6d6d8c738..816beb02f9 100644 --- a/CRM/Mailing/BAO/Mailing.php +++ b/CRM/Mailing/BAO/Mailing.php @@ -2580,10 +2580,7 @@ LEFT JOIN civicrm_mailing_group g ON g.mailing_id = m.id ); } $form->add('checkbox', "{$prefix}updateTemplate", ts('Update Template'), NULL); - - $form->add('checkbox', "{$prefix}saveTemplate", ts('Save As New Template'), NULL, FALSE, - ['onclick' => "showSaveDetails(this, '{$prefix}');"] - ); + $form->add('checkbox', "{$prefix}saveTemplate", ts('Save As New Template'), ['onclick' => "showSaveDetails(this, '{$prefix}');"]); $form->add('text', "{$prefix}saveTemplateName", ts('Template Title')); } -- 2.25.1