From d24d6560d1d82906c9ad4918652811ac4688e791 Mon Sep 17 00:00:00 2001 From: Pradeep Nayak Date: Thu, 23 May 2019 00:52:47 +0100 Subject: [PATCH] dev/financial/issues/56, Fixed Financial item entries --- CRM/Contribute/BAO/Contribution.php | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index 6b7ae24cf4..a057a9674b 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -3788,15 +3788,17 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac elseif ($previousLineItemTotal != $lineItemDetails['line_total']) { $taxAmount -= CRM_Utils_Array::value('tax_amount', CRM_Utils_Array::value($fieldValueId, $previousLineItems), 0); } - $itemParams['amount'] = self::getMultiplier($params['contribution']->contribution_status_id, $context) * $taxAmount; - $itemParams['description'] = $taxTerm; - if ($lineItemDetails['financial_type_id']) { - $itemParams['financial_account_id'] = CRM_Contribute_PseudoConstant::getRelationalFinancialAccount( - $lineItemDetails['financial_type_id'], - 'Sales Tax Account is' - ); + if ($taxAmount != 0) { + $itemParams['amount'] = self::getMultiplier($params['contribution']->contribution_status_id, $context) * $taxAmount; + $itemParams['description'] = $taxTerm; + if ($lineItemDetails['financial_type_id']) { + $itemParams['financial_account_id'] = CRM_Contribute_PseudoConstant::getRelationalFinancialAccount( + $lineItemDetails['financial_type_id'], + 'Sales Tax Account is' + ); + } + CRM_Financial_BAO_FinancialItem::create($itemParams, NULL, $trxnIds); } - CRM_Financial_BAO_FinancialItem::create($itemParams, NULL, $trxnIds); } } } -- 2.25.1