From d21ceb5407bf97e545880d7d76b84927f7015cb3 Mon Sep 17 00:00:00 2001
From: Tim Otten <totten@civicrm.org>
Date: Wed, 6 May 2020 21:51:10 -0700
Subject: [PATCH] E2E_Core_HookTest - Fix test failure due to leak

Before
------

The `HookTest` class fails when running on WordPress.

The event-listener from `testSymfonyListener_names` leaks and remains active during `testSymfonyListener_int`.

After
-----

The `HookTest` class passes when running on WordPress.

The event-listeners from `testSymfonyListener_names` and `testSymfonyListener_int` are cleaned up.
---
 tests/phpunit/E2E/Core/HookTest.php | 58 +++++++++++++++++------------
 1 file changed, 34 insertions(+), 24 deletions(-)

diff --git a/tests/phpunit/E2E/Core/HookTest.php b/tests/phpunit/E2E/Core/HookTest.php
index ab9466dd51..8043c0b34c 100644
--- a/tests/phpunit/E2E/Core/HookTest.php
+++ b/tests/phpunit/E2E/Core/HookTest.php
@@ -19,18 +19,23 @@ class HookTest extends \CiviEndToEndTestCase {
    */
   public function testSymfonyListener_names() {
     $calls = 0;
-    \Civi::dispatcher()
-      ->addListener('hook_civicrm_e2eHookExample', function ($e) use (&$calls) {
-        $calls++;
-        $e->a['foo'] = 'a.name';
-        $e->b->bar = 'b.name';
-      });
-    $a = [];
-    $b = new \stdClass();
-    $this->hookStub(['a', 'b'], $a, $b);
-    $this->assertEquals(1, $calls);
-    $this->assertEquals('a.name', $a['foo']);
-    $this->assertEquals('b.name', $b->bar);
+    $hookExample = function ($e) use (&$calls) {
+      $calls++;
+      $e->a['foo'] = 'a.name';
+      $e->b->bar = 'b.name';
+    };
+    \Civi::dispatcher()->addListener('hook_civicrm_e2eHookExample', $hookExample);
+    try {
+      $a = [];
+      $b = new \stdClass();
+      $this->hookStub(['a', 'b'], $a, $b);
+      $this->assertEquals(1, $calls);
+      $this->assertEquals('a.name', $a['foo']);
+      $this->assertEquals('b.name', $b->bar);
+    }
+    finally {
+      \Civi::dispatcher()->removeListener('hook_civicrm_e2eHookExample', $hookExample);
+    }
   }
 
   /**
@@ -43,18 +48,23 @@ class HookTest extends \CiviEndToEndTestCase {
    */
   public function testSymfonyListener_int() {
     $calls = 0;
-    \Civi::dispatcher()
-      ->addListener('hook_civicrm_e2eHookExample', function ($e) use (&$calls) {
-        $calls++;
-        $e->arg1['foo'] = 'a.num';
-        $e->arg2->bar = 'b.num';
-      });
-    $a = [];
-    $b = new \stdClass();
-    $this->hookStub(2, $a, $b);
-    $this->assertEquals(1, $calls);
-    $this->assertEquals('a.num', $a['foo']);
-    $this->assertEquals('b.num', $b->bar);
+    $hookExample = function ($e) use (&$calls) {
+      $calls++;
+      $e->arg1['foo'] = 'a.num';
+      $e->arg2->bar = 'b.num';
+    };
+    \Civi::dispatcher()->addListener('hook_civicrm_e2eHookExample', $hookExample);
+    try {
+      $a = [];
+      $b = new \stdClass();
+      $this->hookStub(2, $a, $b);
+      $this->assertEquals(1, $calls);
+      $this->assertEquals('a.num', $a['foo']);
+      $this->assertEquals('b.num', $b->bar);
+    }
+    finally {
+      \Civi::dispatcher()->removeListener('hook_civicrm_e2eHookExample', $hookExample);
+    }
   }
 
   /**
-- 
2.25.1