From d17b7894433d4a36054db217dc0aa30d92c9c796 Mon Sep 17 00:00:00 2001 From: pdontthink Date: Tue, 11 Mar 2008 02:45:32 +0000 Subject: [PATCH] Adding FIXME notes git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13026 7612ce4b-ef26-0410-bec9-ea0150e637f0 --- src/configtest.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/configtest.php b/src/configtest.php index a89020bf..b2fbb753 100644 --- a/src/configtest.php +++ b/src/configtest.php @@ -388,9 +388,8 @@ if($data_dir == $attachment_dir) { echo "Checking plugins...
\n"; /* check plugins and themes */ -//FIXME: check requirements given in plugin _info() function, such -// as required PHP extensions, Pear packages, other plugins, SM version, etc -// see development docs for list of returned info from that function +//FIXME: check requirements given in plugin _info() function, such as required PHP extensions, Pear packages, other plugins, SM version, etc see development docs for list of returned info from that function +//FIXME: update this list with most recent contents of the Obsolete category - I think it has changed recently $bad_plugins = array( 'attachment_common', // Integrated into SquirrelMail 1.2 core 'auto_prune_sent', // Obsolete: See Proon Automatic Folder Pruning plugin @@ -443,6 +442,7 @@ if (isset($plugins[0])) { ob_end_clean(); // if plugins output more than newlines and spacing, stop script execution. if (!empty($output)) { +//FIXME: if the output buffer is checked INSIDE the foreach loop above, we can tell the user WHICH plugin has the problem - seems like a good idea $plugin_load_error = 'Some output is produced when plugins are loaded. Usually this means there is an error in one of the plugin setup or configuration files. The output was: '.htmlspecialchars($output); do_err($plugin_load_error); } -- 2.25.1