From d0f74b5372c0961fcbad5e4d3da33e89e45237d1 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Sun, 27 Apr 2014 13:02:31 -0700 Subject: [PATCH] git formatting & comment fixes --- CRM/Upgrade/Incremental/php/FourFive.php | 9 +++++++-- CRM/Upgrade/Incremental/php/FourFour.php | 18 +++++++++++++----- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/CRM/Upgrade/Incremental/php/FourFive.php b/CRM/Upgrade/Incremental/php/FourFive.php index 159a43cfee..961a0fe2d2 100644 --- a/CRM/Upgrade/Incremental/php/FourFive.php +++ b/CRM/Upgrade/Incremental/php/FourFive.php @@ -44,8 +44,11 @@ class CRM_Upgrade_Incremental_php_FourFive { * Note: This function is called iteratively for each upcoming * revision to the database. * - * @param $postUpgradeMessage string, alterable + * @param $preUpgradeMessage * @param $rev string, a version number, e.g. '4.4.alpha1', '4.4.beta3', '4.4.0' + * @param null $currentVer + * + * @internal param string $postUpgradeMessage , alterable * @return void */ function setPreUpgradeMessage(&$preUpgradeMessage, $rev, $currentVer = NULL) { @@ -77,6 +80,8 @@ class CRM_Upgrade_Incremental_php_FourFive { /** * Add defaults for the newly introduced name fields configuration in 'contact_edit_options' setting * + * @param CRM_Queue_TaskContext $ctx + * * @return bool TRUE for success */ static function addNameFieldOptions(CRM_Queue_TaskContext $ctx) { @@ -105,7 +110,7 @@ class CRM_Upgrade_Incremental_php_FourFive { } /** - * Syntatic sugar for adding a task which (a) is in this class and (b) has + * Syntactic sugar for adding a task which (a) is in this class and (b) has * a high priority. * * After passing the $funcName, you can also pass parameters that will go to diff --git a/CRM/Upgrade/Incremental/php/FourFour.php b/CRM/Upgrade/Incremental/php/FourFour.php index 3f9512b69f..429294f66c 100644 --- a/CRM/Upgrade/Incremental/php/FourFour.php +++ b/CRM/Upgrade/Incremental/php/FourFour.php @@ -46,8 +46,11 @@ class CRM_Upgrade_Incremental_php_FourFour { * Note: This function is called iteratively for each upcoming * revision to the database. * - * @param $postUpgradeMessage string, alterable + * @param $preUpgradeMessage * @param $rev string, a version number, e.g. '4.4.alpha1', '4.4.beta3', '4.4.0' + * @param null $currentVer + * + * @internal param string $postUpgradeMessage , alterable * @return void */ function setPreUpgradeMessage(&$preUpgradeMessage, $rev, $currentVer = NULL) { @@ -296,7 +299,7 @@ ALTER TABLE civicrm_dashboard END; "; CRM_Core_DAO::executeQuery($query, array(), TRUE, NULL, FALSE, FALSE); - + // CRM-13998 : missing alter statements for civicrm_report_instance $this->addTask(ts('Confirm civicrm_report_instance sql table for upgrades'), 'updateReportInstanceTable'); @@ -414,6 +417,8 @@ WHERE source_contact_id IS NOT NULL"; /** * Migrate word-replacements from $config to civicrm_word_replacement * + * @param CRM_Queue_TaskContext $ctx + * * @return bool TRUE for success * @see http://issues.civicrm.org/jira/browse/CRM-13187 */ @@ -443,6 +448,9 @@ CREATE TABLE IF NOT EXISTS `civicrm_word_replacement` ( * (the original name in 4.4.0) to "UI_domain_find" (the new name in * 4.4.1). * + * @param CRM_Queue_TaskContext $ctx + * @param $rev + * * @return bool TRUE for success * @see http://issues.civicrm.org/jira/browse/CRM-13655 */ @@ -565,13 +573,13 @@ CREATE TABLE IF NOT EXISTS `civicrm_word_replacement` ( CRM_Core_BAO_WordReplacement::rebuild(); } - + /*** * CRM-13998 missing alter statements for civicrm_report_instance ***/ public function updateReportInstanceTable() { - // add civicrm_report_instance.name + // add civicrm_report_instance.name $sql = "SELECT count(*) FROM information_schema.columns " . "WHERE table_schema = database() AND table_name = 'civicrm_report_instance' AND COLUMN_NAME = 'name' "; @@ -583,7 +591,7 @@ CREATE TABLE IF NOT EXISTS `civicrm_word_replacement` ( $res = CRM_Core_DAO::executeQuery($sql); } - // add civicrm_report_instance args + // add civicrm_report_instance args $sql = "SELECT count(*) FROM information_schema.columns WHERE table_schema = database() AND table_name = 'civicrm_report_instance' AND COLUMN_NAME = 'args' "; -- 2.25.1