From d0d9e105cd0960bc5a2a6f8aee06876ad9f7fbf3 Mon Sep 17 00:00:00 2001 From: eileen Date: Thu, 1 Oct 2020 16:47:10 +1300 Subject: [PATCH] Fix complexity on cache key This seems a likely culprit for https://lab.civicrm.org/dev/core/-/issues/1984 but comments on the gl are inconclusive. Regardless, we can conclude the cacheKey should not cross-populate values from different users --- CRM/Core/BAO/CustomField.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CRM/Core/BAO/CustomField.php b/CRM/Core/BAO/CustomField.php index 41cc7fe7ba..71aded4a53 100644 --- a/CRM/Core/BAO/CustomField.php +++ b/CRM/Core/BAO/CustomField.php @@ -332,7 +332,7 @@ class CRM_Core_BAO_CustomField extends CRM_Core_DAO_CustomField { $cacheKey .= $inline ? '_1_' : '_0_'; $cacheKey .= $onlyParent ? '_1_' : '_0_'; $cacheKey .= $onlySubType ? '_1_' : '_0_'; - $cacheKey .= $checkPermission ? '_1_' : '_0_'; + $cacheKey .= $checkPermission ? '_1_' . CRM_Core_Session::getLoggedInContactID() . '_' : '_0_0_'; $cacheKey .= '_' . CRM_Core_Config::domainID() . '_'; $cgTable = CRM_Core_DAO_CustomGroup::getTableName(); -- 2.25.1