From d042125860b1badfe4130d07f44c1bb9284811a3 Mon Sep 17 00:00:00 2001 From: Camilo Rodriguez Date: Tue, 29 May 2018 18:12:32 +0000 Subject: [PATCH] CRM-151: Allow to Edit Recurring Contributions From Membership A check for payment processor id was causing all recurring contributions shown on membership details view to never show the 'Edit' action, as this value was not availble. Fixed by removing check, as it is no longer required. --- CRM/Member/Page/RecurringContributions.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CRM/Member/Page/RecurringContributions.php b/CRM/Member/Page/RecurringContributions.php index 67ef43d1d2..67b2b93938 100644 --- a/CRM/Member/Page/RecurringContributions.php +++ b/CRM/Member/Page/RecurringContributions.php @@ -112,14 +112,18 @@ class CRM_Member_Page_RecurringContributions extends CRM_Core_Page { */ private function setActionsForRecurringContribution($recurID, &$recurringContribution) { $action = array_sum(array_keys($this->recurLinks($recurID))); + // no action allowed if it's not active $recurringContribution['is_active'] = ($recurringContribution['contribution_status_id'] != 3); + if ($recurringContribution['is_active']) { $details = CRM_Contribute_BAO_ContributionRecur::getSubscriptionDetails($recurringContribution['id'], 'recur'); $hideUpdate = $details->membership_id & $details->auto_renew; - if ($hideUpdate || empty($details->processor_id)) { + + if ($hideUpdate) { $action -= CRM_Core_Action::UPDATE; } + $recurringContribution['action'] = CRM_Core_Action::formLink( $this->recurLinks($recurID), $action, -- 2.25.1