From cfcb7676a20902f198774dddd149749dc0e3752b Mon Sep 17 00:00:00 2001
From: "Donald A. Lobo" <lobo@civicrm.org>
Date: Wed, 20 Mar 2013 10:49:14 -0700
Subject: [PATCH] fix strict notices from PHP 5.4

---
 CRM/Activity/Form/Activity.php      |  2 +-
 CRM/Activity/Form/ActivityLinks.php | 16 ++++++++++------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/CRM/Activity/Form/Activity.php b/CRM/Activity/Form/Activity.php
index 24338aa987..205d12616a 100644
--- a/CRM/Activity/Form/Activity.php
+++ b/CRM/Activity/Form/Activity.php
@@ -647,7 +647,7 @@ class CRM_Activity_Form_Activity extends CRM_Contact_Form_Task {
     }
 
     //build other activity links
-    CRM_Activity_Form_ActivityLinks::buildQuickForm();
+    CRM_Activity_Form_ActivityLinks::commonBuildQuickForm($this);
 
     //enable form element (ActivityLinks sets this true)
     $this->assign('suppressForm', FALSE);
diff --git a/CRM/Activity/Form/ActivityLinks.php b/CRM/Activity/Form/ActivityLinks.php
index 38c9a282b6..30c839eb1d 100644
--- a/CRM/Activity/Form/ActivityLinks.php
+++ b/CRM/Activity/Form/ActivityLinks.php
@@ -39,7 +39,11 @@
  */
 class CRM_Activity_Form_ActivityLinks extends CRM_Core_Form {
   public function buildQuickForm() {
-    $contactId = CRM_Utils_Request::retrieve('cid', 'Positive', $this);
+    self::commonBuildQuickForm($this);
+  }
+
+  static function commonBuildQuickForm($self) {
+    $contactId = CRM_Utils_Request::retrieve('cid', 'Positive', $self);
     if (!$contactId) {
       $contactId = CRM_Utils_Request::retrieve('cid', 'Positive', CRM_Core_DAO::$_nullObject, FALSE, NULL, $_REQUEST);
     }
@@ -60,7 +64,7 @@ class CRM_Activity_Form_ActivityLinks extends CRM_Core_Form {
       'Text Message (SMS)',
       'label'
     );
-   
+
     if (CRM_Utils_Mail::validOutBoundMail() && $contactId) {
       list($name, $email, $doNotEmail, $onHold, $isDeseased) = CRM_Contact_BAO_Contact::getContactDetails($contactId);
       if (!$doNotEmail && $email && !$isDeseased) {
@@ -72,7 +76,7 @@ class CRM_Activity_Form_ActivityLinks extends CRM_Core_Form {
       // Check for existence of a mobile phone and ! do not SMS privacy setting
       $mobileTypeID = CRM_Core_OptionGroup::getValue('phone_type', 'Mobile', 'name');
       list($name, $phone, $doNotSMS) = CRM_Contact_BAO_Contact_Location::getPhoneDetails($contactId, $mobileTypeID);
-      
+
       if (!$doNotSMS && $phone) {
         $sendSMS = array($SMSId  => ts('Send SMS'));
         $activityTypes += $sendSMS;
@@ -106,10 +110,10 @@ class CRM_Activity_Form_ActivityLinks extends CRM_Core_Form {
       }
     }
 
-    $this->assign('activityTypes', $activityTypes);
-    $this->assign('urls', $urls);
+    $self->assign('activityTypes', $activityTypes);
+    $self->assign('urls', $urls);
 
-    $this->assign('suppressForm', TRUE);
+    $self->assign('suppressForm', TRUE);
   }
 }
 
-- 
2.25.1