From cda69f2fda4d952ae838e276f1b28271dd4752dc Mon Sep 17 00:00:00 2001 From: Matthew Wire Date: Fri, 5 Jun 2020 10:17:50 +0100 Subject: [PATCH] Remove a warning from logs as this triggers everytime the function is called whether or not legacy params are actually merged --- Civi/Payment/PropertyBag.php | 1 - tests/phpunit/Civi/Payment/PropertyBagTest.php | 1 - 2 files changed, 2 deletions(-) diff --git a/Civi/Payment/PropertyBag.php b/Civi/Payment/PropertyBag.php index 8878734691..a97c8d113f 100644 --- a/Civi/Payment/PropertyBag.php +++ b/Civi/Payment/PropertyBag.php @@ -296,7 +296,6 @@ class PropertyBag implements \ArrayAccess { * @param array $data */ public function mergeLegacyInputParams($data) { - $this->legacyWarning('We have merged input params into the property bag for now but please rewrite code to not use this.'); foreach ($data as $key => $value) { if ($value !== NULL && $value !== '') { $this->offsetSet($key, $value); diff --git a/tests/phpunit/Civi/Payment/PropertyBagTest.php b/tests/phpunit/Civi/Payment/PropertyBagTest.php index 4befbec00c..f5c7b59e28 100644 --- a/tests/phpunit/Civi/Payment/PropertyBagTest.php +++ b/tests/phpunit/Civi/Payment/PropertyBagTest.php @@ -103,7 +103,6 @@ class PropertyBagTest extends \PHPUnit\Framework\TestCase implements HeadlessInt 'contactID' => 123, 'contributionRecurID' => 456, ]); - $this->assertEquals('We have merged input params into the property bag for now but please rewrite code to not use this.', $propertyBag->lastWarning); $this->assertEquals(123, $propertyBag->getContactID()); $this->assertEquals(456, $propertyBag->getContributionRecurID()); } -- 2.25.1