From cc1aa5e290f21ed32f64a3ec5a9826ae226b54d3 Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Mon, 1 Feb 2021 14:43:33 -0500
Subject: [PATCH] Afform - Rename 'Forms' menu item to 'Form Builder'

---
 .../admin/CRM/AfformAdmin/Page/Base.php       |  2 +-
 ext/afform/admin/CRM/AfformAdmin/Upgrader.php | 22 +++++++++++++++++--
 ext/afform/admin/ang/afAdmin/afAdminList.html |  2 +-
 3 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/ext/afform/admin/CRM/AfformAdmin/Page/Base.php b/ext/afform/admin/CRM/AfformAdmin/Page/Base.php
index 31338e5eaf..fc22b35b94 100644
--- a/ext/afform/admin/CRM/AfformAdmin/Page/Base.php
+++ b/ext/afform/admin/CRM/AfformAdmin/Page/Base.php
@@ -16,7 +16,7 @@ class CRM_AfformAdmin_Page_Base extends CRM_Core_Page {
 
   public function run() {
     $breadCrumb = [
-      'title' => ts('Forms'),
+      'title' => ts('Form Builder'),
       'url' => CRM_Utils_System::url('civicrm/admin/afform', NULL, FALSE, '/'),
     ];
     CRM_Utils_System::appendBreadCrumb([$breadCrumb]);
diff --git a/ext/afform/admin/CRM/AfformAdmin/Upgrader.php b/ext/afform/admin/CRM/AfformAdmin/Upgrader.php
index f129852e72..5a402f727a 100644
--- a/ext/afform/admin/CRM/AfformAdmin/Upgrader.php
+++ b/ext/afform/admin/CRM/AfformAdmin/Upgrader.php
@@ -23,12 +23,13 @@ class CRM_AfformAdmin_Upgrader extends CRM_AfformAdmin_Upgrader_Base {
       if (!$existing) {
         civicrm_api3('Navigation', 'create', [
           'parent_id' => 'Customize Data and Screens',
-          'label' => E::ts('Forms'),
+          'label' => E::ts('Form Builder'),
           'weight' => 1,
-          'name' => 'afform_gui',
+          'name' => 'afform_admin',
           'permission' => 'administer CiviCRM',
           'url' => 'civicrm/admin/afform',
           'is_active' => 1,
+          'icon' => 'crm-i fa-list-alt'
         ]);
       }
     }
@@ -48,4 +49,21 @@ class CRM_AfformAdmin_Upgrader extends CRM_AfformAdmin_Upgrader_Base {
     ]);
   }
 
+  /**
+   * Update menu item
+   *
+   * @return TRUE on success
+   * @throws Exception
+   */
+   public function upgrade_0001() {
+     $this->ctx->log->info('Applying update 0001');
+     \Civi\Api4\Navigation::update(FALSE)
+       ->addValue('icon', 'crm-i fa-list-alt')
+       ->addValue('label', E::ts('Form Builder'))
+       ->addValue('name', 'afform_admin')
+       ->addWhere('name', '=', 'afform_gui')
+       ->execute();
+     return TRUE;
+   }
+
 }
diff --git a/ext/afform/admin/ang/afAdmin/afAdminList.html b/ext/afform/admin/ang/afAdmin/afAdminList.html
index 430f030985..02dd53f96b 100644
--- a/ext/afform/admin/ang/afAdmin/afAdminList.html
+++ b/ext/afform/admin/ang/afAdmin/afAdminList.html
@@ -1,5 +1,5 @@
 <div id="bootstrap-theme" class="afadmin-list">
-  <h1 crm-page-title>{{:: ts('Configurable Forms') }}</h1>
+  <h1 crm-page-title>{{:: ts('Form Builder') }}</h1>
 
   <ul class="nav nav-tabs">
     <li role="presentation" ng-repeat="tab in $ctrl.tabs" ng-class="{active: tab.name === $ctrl.tab}">
-- 
2.25.1