From cb09fd1c5e65eabf2dc915fe5d6053b0c377731f Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Tue, 1 Jun 2021 11:50:42 +1200 Subject: [PATCH] [Ref] remove never-passed param Removes a parameter that is never passed in --- CRM/Contact/BAO/GroupContactCache.php | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/CRM/Contact/BAO/GroupContactCache.php b/CRM/Contact/BAO/GroupContactCache.php index e7bed41265..789435e02e 100644 --- a/CRM/Contact/BAO/GroupContactCache.php +++ b/CRM/Contact/BAO/GroupContactCache.php @@ -99,18 +99,15 @@ AND ( * * @param int $groupID * The group ID. - * @param bool $includeHiddenGroups - * Hidden groups are excluded by default. * - * @return string - * the sql query which lists the groups that need to be refreshed + * @return bool */ - public static function shouldGroupBeRefreshed($groupID, $includeHiddenGroups = FALSE) { - $query = self::groupRefreshedClause("g.id = %1", $includeHiddenGroups); + public static function shouldGroupBeRefreshed($groupID): bool { + $query = self::groupRefreshedClause('g.id = %1'); $params = [1 => [$groupID, 'Integer']]; // if the query returns the group ID, it means the group is a valid candidate for refreshing - return CRM_Core_DAO::singleValueQuery($query, $params); + return (bool) CRM_Core_DAO::singleValueQuery($query, $params); } /** -- 2.25.1