From c29cba70fc29727e76d619a894734776b15e4088 Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Tue, 17 Oct 2023 16:08:49 +0800 Subject: [PATCH] DEV: Fix broken ARM64 build (#745) Why this change? The `docker tag discourse/base:aarch64-slim localhost:5000/discourse/base:aarch64-slim ` command broked in 0c93b2207d22b9de69b503460dc269f8b33935c2 because there is no `aarch64-slim` image being built. Instead, the `ruby auto_build.rb base_slime_64` command builds an image with the `discourse/base:build_slim_arm64` tag. What does this change do? This change removes the tagging command because it is pointless for us to tag it. --- .github/workflows/build.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c3f1762..1baa516 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -4,7 +4,7 @@ on: - main pull_request: schedule: - - cron: '0 0 * * *' + - cron: "0 0 * * *" concurrency: group: build-${{ format('{0}-{1}', github.head_ref || github.run_number, github.job) }} @@ -122,11 +122,6 @@ jobs: aarch64: runs-on: ubuntu-latest needs: base - services: - registry: - image: registry - ports: - - 5000:5000 steps: - uses: actions/checkout@v3 with: @@ -139,11 +134,10 @@ jobs: - name: build slim image run: | cd image && ruby auto_build.rb base_slim_arm64 - docker tag discourse/base:aarch64-slim localhost:5000/discourse/base:build_slim_arm64 - name: tag slim image as release working-directory: image/base run: | - docker tag discourse/base:aarch64-slim discourse/base:aarch64 + docker tag discourse/base:build_slim_arm64 discourse/base:aarch64 - name: Print summary run: docker images discourse/base - name: push to dockerhub -- 2.25.1