From c24fc08381ca290583e39b44377fb26e565297a6 Mon Sep 17 00:00:00 2001 From: Sarah Gladstone Date: Tue, 29 Apr 2014 10:11:49 -0700 Subject: [PATCH] Update Membership.php Check if status_id is empty before using it to look inside an array --- CRM/Member/Form/Membership.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CRM/Member/Form/Membership.php b/CRM/Member/Form/Membership.php index 7f6fc3225c..c298cca5fd 100644 --- a/CRM/Member/Form/Membership.php +++ b/CRM/Member/Form/Membership.php @@ -956,8 +956,6 @@ WHERE id IN ( ' . implode(' , ', array_keys($membershipType)) . ' )'; // if end date is set, ensure that start date is also set // and that end date is later than start date - // If selected membership type has duration unit as 'lifetime' - // and end date is set, then give error $endDate = NULL; if (!empty($params['end_date'])) { $endDate = CRM_Utils_Date::processDate($params['end_date']); @@ -984,7 +982,7 @@ WHERE id IN ( ' . implode(' , ', array_keys($membershipType)) . ' )'; foreach($tmp_statuses as $cur_stat) { $status_ids[] = $cur_stat['id']; } - if( in_array( $params['status_id'] , $status_ids) == false ) { + if( $params['status_id'] == false || in_array( $params['status_id'] , $status_ids) == false ) { $errors['status_id'] = ts('Please enter a status that does NOT represent a current membership status.'); $errors['is_override'] = ts('This must be checked because you set an End Date for a lifetime membership'); } -- 2.25.1