From c1aac8ad6e4f30e7338b33c15b5ac96e3cd7722f Mon Sep 17 00:00:00 2001 From: Pradeep Nayak Date: Sun, 23 Jun 2019 21:09:58 +0100 Subject: [PATCH] Use api to create activity and removed hardcoded status id --- CRM/Financial/BAO/ExportFormat.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/CRM/Financial/BAO/ExportFormat.php b/CRM/Financial/BAO/ExportFormat.php index b352f9bb84..cf41115096 100644 --- a/CRM/Financial/BAO/ExportFormat.php +++ b/CRM/Financial/BAO/ExportFormat.php @@ -209,11 +209,10 @@ abstract class CRM_Financial_BAO_ExportFormat { // create activity. $subject .= ' ' . ts('Batch') . '[' . $values['title'] . ']'; - $activityTypes = CRM_Core_PseudoConstant::activityType(TRUE, FALSE, FALSE, 'name'); $activityParams = [ - 'activity_type_id' => array_search('Export Accounting Batch', $activityTypes), + 'activity_type_id' => 'Export Accounting Batch', 'subject' => $subject, - 'status_id' => 2, + 'status_id' => 'Completed', 'activity_date_time' => date('YmdHis'), 'source_contact_id' => $session->get('userID'), 'source_record_id' => $values['id'], @@ -226,8 +225,7 @@ abstract class CRM_Financial_BAO_ExportFormat { 'upload_date' => date('YmdHis'), ], ]; - - CRM_Activity_BAO_Activity::create($activityParams); + civicrm_api3('Activity', 'create', $activityParams); } /** -- 2.25.1