From bd89ce83294dd7a9f9f7e024b427164671101976 Mon Sep 17 00:00:00 2001 From: demeritcowboy Date: Sun, 17 Sep 2023 13:55:03 -0400 Subject: [PATCH] add comments --- CRM/Core/CodeGen/I18n.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CRM/Core/CodeGen/I18n.php b/CRM/Core/CodeGen/I18n.php index f7c4f908f8..2f71133ba4 100644 --- a/CRM/Core/CodeGen/I18n.php +++ b/CRM/Core/CodeGen/I18n.php @@ -38,6 +38,11 @@ class CRM_Core_CodeGen_I18n extends CRM_Core_CodeGen_BaseTask { foreach ($table['fields'] as $field) { if ($field['localizable']) { $required = $field['required'] ? ' NOT NULL' : ''; + // The setting of default `''` for required fields is a workaround + // that makes it work similar to turning off STRICT_TRANS_TABLES, but + // means that the database cannot enforce required fields since this + // definition is not the same as "required". Ideally, required fields + // would be included in every INSERT statement. $default = $field['default'] ? ' DEFAULT ' . $field['default'] : ($field['required'] ? " DEFAULT '' " : ''); $comment = $field['comment'] ? " COMMENT '" . $field['comment'] . "'" : ''; $columns[$table['name']][$field['name']] = $field['sqlType'] . $required . $default . $comment; -- 2.25.1