From bcbc2c645effde0fb685f294294cd9d216e412ca Mon Sep 17 00:00:00 2001 From: eileen Date: Mon, 14 Dec 2020 16:28:41 +1300 Subject: [PATCH] Stop passing ids as reference There are 3 remaining places in the code that call Membership::create with the ids variable. From my digging none of them use ids afterwards so there is no need to pass by reference --- CRM/Member/BAO/Membership.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CRM/Member/BAO/Membership.php b/CRM/Member/BAO/Membership.php index 16f57a2f26..e85498bd67 100644 --- a/CRM/Member/BAO/Membership.php +++ b/CRM/Member/BAO/Membership.php @@ -242,7 +242,7 @@ class CRM_Member_BAO_Membership extends CRM_Member_DAO_Membership { * * @throws CRM_Core_Exception */ - public static function create(&$params, &$ids = []) { + public static function create(&$params, $ids = []) { // always calculate status if is_override/skipStatusCal is not true. // giving respect to is_override during import. CRM-4012 -- 2.25.1