From bc0de17efcdad34c2b78c77c40078445d2f36904 Mon Sep 17 00:00:00 2001 From: colemanw Date: Sat, 14 Oct 2023 17:09:01 -0400 Subject: [PATCH] Navigation - Add deprecation notice and remove redundant serialization --- CRM/Core/BAO/Navigation.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/CRM/Core/BAO/Navigation.php b/CRM/Core/BAO/Navigation.php index c9a4c61202..f81e4fa258 100644 --- a/CRM/Core/BAO/Navigation.php +++ b/CRM/Core/BAO/Navigation.php @@ -97,10 +97,6 @@ class CRM_Core_BAO_Navigation extends CRM_Core_DAO_Navigation { $params['weight'] = self::calculateWeight(CRM_Utils_Array::value('parent_id', $params)); } - if (array_key_exists('permission', $params) && is_array($params['permission'])) { - $params['permission'] = implode(',', $params['permission']); - } - return self::writeRecord($params); } @@ -594,6 +590,7 @@ ORDER BY weight"; * @deprecated - use API */ public static function processRename($nodeID, $label) { + CRM_Core_Error::deprecatedFunctionWarning('writeRecord'); self::writeRecord(['id' => $nodeID, 'label' => $label]); } @@ -604,6 +601,7 @@ ORDER BY weight"; * @deprecated - use API */ public static function processDelete($nodeID) { + CRM_Core_Error::deprecatedFunctionWarning('writeRecord'); self::deleteRecord(['id' => $nodeID]); } -- 2.25.1