From b9c07b7fc63fef25cc1a5b09d5d5c9b63582e504 Mon Sep 17 00:00:00 2001 From: eileen Date: Fri, 10 Jan 2020 01:24:10 +1300 Subject: [PATCH] Remove never passed-in parameter from addPayments --- CRM/Contribute/BAO/Contribution.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index befc6c0b89..7018117517 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -4840,11 +4840,10 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac * Replace with Order.create->Payment.create flow. * * @param array $contributions - * @param string $contributionStatusId * * @throws \CiviCRM_API3_Exception */ - public static function addPayments($contributions, $contributionStatusId = NULL) { + public static function addPayments($contributions) { // get financial trxn which is a payment $ftSql = "SELECT ft.id, ft.total_amount FROM civicrm_financial_trxn ft @@ -4854,9 +4853,7 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac 'labelColumn' => 'name', ]); foreach ($contributions as $contribution) { - if (!($contributionStatus[$contribution->contribution_status_id] == 'Partially paid' - || CRM_Utils_Array::value($contributionStatusId, $contributionStatus) == 'Partially paid') - ) { + if ($contributionStatus[$contribution->contribution_status_id] !== 'Partially paid') { continue; } $ftDao = CRM_Core_DAO::executeQuery($ftSql, [ -- 2.25.1