From b8d390b06f745989d1a1fd89280f06dd7784538c Mon Sep 17 00:00:00 2001 From: Jack Allnutt Date: Fri, 5 Jul 2013 23:20:28 +0100 Subject: [PATCH] RPL_NAMEREPLY: Don't loop over the whole nick when extracting modes --- server/irc/commands.js | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/server/irc/commands.js b/server/irc/commands.js index 0dc53c0..6979af8 100644 --- a/server/irc/commands.js +++ b/server/irc/commands.js @@ -270,18 +270,17 @@ handlers = { var members = command.trailing.split(' '); var member_list = []; var that = this; - var i = 0; _.each(members, function (member) { - var j, k, modes = []; + var i = 0, + j = 0, + modes = []; // Make sure we have some prefixes already if (that.irc_connection.options.PREFIX) { - for (j = 0; j < member.length; j++) { - for (k = 0; k < that.irc_connection.options.PREFIX.length; k++) { - if (member.charAt(j) === that.irc_connection.options.PREFIX[k].symbol) { - modes.push(that.irc_connection.options.PREFIX[k].mode); - i++; - } + for (j = 0; j < that.irc_connection.options.PREFIX.length; j++) { + if (member.charAt(i) === that.irc_connection.options.PREFIX[j].symbol) { + modes.push(that.irc_connection.options.PREFIX[j].mode); + i++; } } } -- 2.25.1