From b0963383c05818a1eb2250c3f97961886c6c0599 Mon Sep 17 00:00:00 2001 From: pdontthink Date: Sun, 1 Apr 2007 23:31:44 +0000 Subject: [PATCH] Shifting the location of bind_textdomain_codeset() in the SM wrapper functions git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12358 7612ce4b-ef26-0410-bec9-ea0150e637f0 --- include/languages.php | 56 +++++++++++++++++++++---------------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/include/languages.php b/include/languages.php index 592f1f54..aef1a200 100644 --- a/include/languages.php +++ b/include/languages.php @@ -28,21 +28,26 @@ * plugins when changing into their own text domain * and back again. * - * Note that plugins using this function must have + * Note that if plugins using this function have * their translation files located in the SquirrelMail - * locale directory. + * locale directory, the second argument is optional. * * @param string $domain_name The name of the text domain * (usually the plugin name, or * "squirrelmail") being switched to. + * @param string $directory The directory that contains + * all translations for the domain + * (OPTIONAL; default is SquirrelMail + * locale directory). * * @return void * * @since 1.5.2 and 1.4.10 */ -function sq_change_text_domain($domain_name) { +function sq_change_text_domain($domain_name, $directory='') { + + if (empty($directory)) $directory = SM_PATH . 'locale/'; - global $languages, $sm_notAlias; static $domains_already_seen = array(); // only need to call bindtextdomain() once @@ -54,21 +59,9 @@ function sq_change_text_domain($domain_name) { $domains_already_seen[] = $domain_name; - sq_bindtextdomain($domain_name, SM_PATH . 'locale/'); + sq_bindtextdomain($domain_name, $directory); sq_textdomain($domain_name); - // set codeset in order to avoid gettext charset conversions - if (function_exists('bind_textdomain_codeset') - && isset($languages[$sm_notAlias]['CHARSET'])) { - - // Japanese translation uses different internal charset - if ($sm_notAlias == 'ja_JP') { - bind_textdomain_codeset ($domain_name, 'EUC-JP'); - } else { - bind_textdomain_codeset ($domain_name, $languages[$sm_notAlias]['CHARSET']); - } - - } } /** @@ -77,7 +70,11 @@ function sq_change_text_domain($domain_name) { * Wrapper solves differences between php versions in order to provide * ngettext support. Should be used if translation uses ngettext * functions. - * @since 1.5.1 + * + * This also provides a bind_textdomain_codeset call to make sure the + * domain's encoding will not be overridden. + * + * @since 1.4.10 and 1.5.1 * @param string $domain gettext domain name * @param string $dir directory that contains all translations * @return string path to translation directory @@ -95,6 +92,19 @@ function sq_bindtextdomain($domain,$dir) { $dir=bindtextdomain($domain,$dir); + // set codeset in order to avoid gettext charset conversions + if (function_exists('bind_textdomain_codeset') + && isset($languages[$sm_notAlias]['CHARSET'])) { + + // Japanese translation uses different internal charset + if ($sm_notAlias == 'ja_JP') { + bind_textdomain_codeset ($domain_name, 'EUC-JP'); + } else { + bind_textdomain_codeset ($domain_name, $languages[$sm_notAlias]['CHARSET']); + } + + } + return $dir; } @@ -430,16 +440,6 @@ function set_up_language($sm_language, $do_search = false, $default = false) { sq_bindtextdomain( 'squirrelmail', SM_PATH . 'locale/' ); sq_textdomain( 'squirrelmail' ); - // set codeset in order to avoid gettext charset conversions - if (function_exists('bind_textdomain_codeset')) { - // Japanese translation uses different internal charset - if ($sm_notAlias == 'ja_JP') { - bind_textdomain_codeset ('squirrelmail', 'EUC-JP'); - } else { - bind_textdomain_codeset ('squirrelmail', $languages[$sm_notAlias]['CHARSET'] ); - } - } - // Use LOCALE key, if it is set. if (isset($languages[$sm_notAlias]['LOCALE'])){ $longlocale=$languages[$sm_notAlias]['LOCALE']; -- 2.25.1