From b01812e5938609ef68046bdcd726e05c9b2dc3b5 Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Tue, 20 Jan 2015 10:03:49 -0500
Subject: [PATCH] CRM-15842 - Custom group form cleanup

----------------------------------------
* CRM-15842: Custom field form improvements
  https://issues.civicrm.org/jira/browse/CRM-15842
---
 CRM/Core/Form.php                   |  4 ++
 CRM/Custom/Form/Group.php           |  2 +-
 templates/CRM/Custom/Form/Group.tpl | 72 ++++++++++++-----------------
 3 files changed, 35 insertions(+), 43 deletions(-)

diff --git a/CRM/Core/Form.php b/CRM/Core/Form.php
index b62ce0277a..1877210f4c 100644
--- a/CRM/Core/Form.php
+++ b/CRM/Core/Form.php
@@ -513,6 +513,10 @@ class CRM_Core_Form extends HTML_QuickForm_Page {
     foreach ($params as $button) {
       $attrs = array('class' => 'crm-form-submit') + (array) CRM_Utils_Array::value('js', $button);
 
+      if (!empty($button['class'])) {
+        $attrs['class'] .= ' ' . $button['class'];
+      }
+
       if (!empty($button['isDefault'])) {
         $attrs['class'] .= ' default';
       }
diff --git a/CRM/Custom/Form/Group.php b/CRM/Custom/Form/Group.php
index 61b90ecd10..7bcee88ffd 100644
--- a/CRM/Custom/Form/Group.php
+++ b/CRM/Custom/Form/Group.php
@@ -387,7 +387,7 @@ class CRM_Custom_Form_Group extends CRM_Core_Form {
       ),
     );
     if (!$this->_isGroupEmpty && !empty($this->_subtypes)) {
-      $buttons[0]['js'] = array('onclick' => "return warnDataLoss()");
+      $buttons[0]['class'] = 'crm-warnDataLoss';
     }
     $this->addButtons($buttons);
 
diff --git a/templates/CRM/Custom/Form/Group.tpl b/templates/CRM/Custom/Form/Group.tpl
index 998f3ebc16..6ef11d74f5 100644
--- a/templates/CRM/Custom/Form/Group.tpl
+++ b/templates/CRM/Custom/Form/Group.tpl
@@ -87,43 +87,31 @@
 <script type="text/Javascript">
 CRM.$(function($) {
 
-  showHideStyle();
-  $('#extends_0').change(function() {
-    showHideStyle();
-  });
+  $('#extends_0').each(showHideStyle).change(showHideStyle);
 
-  var  isGroupEmpty = "{/literal}{$isGroupEmpty}{literal}";
+  var isGroupEmpty = "{/literal}{$isGroupEmpty}{literal}";
   if (isGroupEmpty) {
     showRange(true);
   }
-  $('#is_multiple').click(function() {
-    showRange();
-  });
+  $('#is_multiple').click(showRange);
 
   function showHideStyle() {
-    var isShow  = false;
-    var extend  = $('#extends_0').val();
-
-    var contactTypes    = {/literal}{$contactTypes}{literal};
-    var showStyle       = "{/literal}{$showStyle}{literal}";
-    var showMultiple    = "{/literal}{$showMultiple}{literal}";
-    var showMaxMultiple = "{/literal}{$showMaxMultiple}{literal}";
-
-    if ($.inArray(extend, contactTypes) >= 0) {
-      isShow  = true;
-    }
+    var
+      extend = $(this).val(),
+      contactTypes = {/literal}{$contactTypes}{literal},
+      showStyle = "{/literal}{$showStyle}{literal}",
+      showMultiple = "{/literal}{$showMultiple}{literal}",
+      showMaxMultiple = "{/literal}{$showMaxMultiple}{literal}",
+      isShow = ($.inArray(extend, contactTypes) >= 0);
 
     if (isShow) {
-      $("tr#style").show();
-      $("tr#is_multiple").show();
+      $("tr#style, tr#is_multiple").show();
       if ($('#is_multiple :checked').length) {
         $("tr#multiple").show();
       }
     }
     else {
-      $("tr#style").hide();
-      $("tr#is_multiple").hide();
-      $("tr#multiple").hide();
+      $("tr#style, tr#is_multiple, tr#multiple").hide();
     }
 
     if (showStyle) {
@@ -131,14 +119,13 @@ CRM.$(function($) {
     }
 
     if (showMultiple) {
-      $("tr#style").show();
-      $("tr#is_multiple").show();
+      $("tr#style, tr#is_multiple").show();
     }
 
     if (!showMaxMultiple) {
       $("tr#multiple").hide();
     }
-    else if($( '#is_multiple').prop('checked')) {
+    else if ($('#is_multiple').prop('checked')) {
       $("tr#multiple").show();
     }
   }
@@ -152,7 +139,7 @@ CRM.$(function($) {
     else {
       $('#collapse_display').prop('checked', 'checked');
       $("tr#multiple").hide();
-      if (!onFormLoad) {
+      if (onFormLoad !== true) {
         $("select#style option[value='Inline']").prop("selected", true);
       }
     }
@@ -169,23 +156,24 @@ CRM.$(function($) {
       subtypes.style.display = 'inline';
     }
   }
-});
 
-function warnDataLoss() {
-  var submittedSubtypes = cj('#extends_1').val();
-  var defaultSubtypes   = {/literal}{$defaultSubtypes}{literal};
+  // When removing sub-types
+  $('.crm-warnDataLoss').on('click', function() {
+    var submittedSubtypes = $('#extends_1').val();
+    var defaultSubtypes = {/literal}{$defaultSubtypes}{literal};
+
+    var warning = false;
+    $.each(defaultSubtypes, function(index, subtype) {
+      if ($.inArray(subtype, submittedSubtypes) < 0) {
+        warning = true;
+      }
+    });
 
-  var warning = false;
-  cj.each(defaultSubtypes, function(index, subtype) {
-    if (cj.inArray(subtype, submittedSubtypes) < 0) {
-      warning = true;
+    if (warning) {
+      return confirm({/literal}'{ts escape='js'}Warning: You have chosen to remove one or more subtypes. This will cause any custom data records associated with those subtypes to be removed.{/ts}'{literal});
     }
+    return true;
   });
-
-  if (warning) {
-    return confirm( 'One or more subtypes has been un-selected from the list. Any custom data associated with un-selected subtype would be removed. Click OK to proceed.' );
-  }
-  return true;
-}
+});
 </script>
 {/literal}
-- 
2.25.1