From af719516df55ae5432e0ddc9f369768a83e8c07f Mon Sep 17 00:00:00 2001 From: Tim Otten Date: Fri, 6 May 2022 15:48:43 -0700 Subject: [PATCH] (E2E) testErrorChrome - Skip Backdrop and D8+ (much like D7) This test was added during 5.50.alpha (#23257, #22805). It's purpose is to assert that the page-chrome/site-wide-template is present on certain error-messages; however, the underlying behavior was only implemented on WordPress. It has not yet been implemented on other CMS. Before ------ * __WordPress__: Runs testErrorChrome. Expected to pass. * __Drupal 7__: Skip testErrorChrome (mostly) because it is expected to fail. * __Drupal 8+, Backdrop__: Runs testErrorChrome. Fails. After ----- * __WordPress__: Runs testErrorChrome. Expected to pass. * ___Drupal 7, Drupal 8+, Backdrop__: Skip testErrorChrome (mostly) because it is expected to fail. Comment ------- It still runs `testErrorChrome` for `permission` errors; per MM discussion, it appears that this does actually work, but we need to tune assertion for BD+D8. --- tests/phpunit/E2E/Core/ErrorTest.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/phpunit/E2E/Core/ErrorTest.php b/tests/phpunit/E2E/Core/ErrorTest.php index 90f7c4edda..1f24812bdc 100644 --- a/tests/phpunit/E2E/Core/ErrorTest.php +++ b/tests/phpunit/E2E/Core/ErrorTest.php @@ -31,6 +31,8 @@ class ErrorTest extends \CiviEndToEndTestCase { // Format: "{$uf}_{$testFunc}_{$errorType}" '/WordPress_testErrorStatus_(fatal|exception)/', '/Drupal_testErrorChrome_(fatal|exception)/', + '/Drupal8_testErrorChrome_(fatal|exception)/', + '/Backdrop_testErrorChrome_(fatal|exception)/', ]; public function getErrorTypes() { -- 2.25.1