From ab8c864ecfcf7654f5e352b994e50aea553de90f Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Mon, 19 Jul 2021 13:47:45 -0400
Subject: [PATCH] APIv4 - Add test to ensure superfluous option groups are not
 created

---
 tests/phpunit/api/v4/Action/BasicCustomFieldTest.php | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/phpunit/api/v4/Action/BasicCustomFieldTest.php b/tests/phpunit/api/v4/Action/BasicCustomFieldTest.php
index 28565d4d08..d9d1c2e311 100644
--- a/tests/phpunit/api/v4/Action/BasicCustomFieldTest.php
+++ b/tests/phpunit/api/v4/Action/BasicCustomFieldTest.php
@@ -22,6 +22,7 @@ namespace api\v4\Action;
 use Civi\Api4\Contact;
 use Civi\Api4\CustomField;
 use Civi\Api4\CustomGroup;
+use Civi\Api4\OptionGroup;
 use Civi\Api4\Relationship;
 use Civi\Api4\RelationshipCache;
 
@@ -86,6 +87,7 @@ class BasicCustomFieldTest extends BaseCustomValueTest {
   }
 
   public function testWithTwoFields() {
+    $optionGroupCount = OptionGroup::get(FALSE)->selectRowCount()->execute()->count();
 
     // First custom set
     CustomGroup::create(FALSE)
@@ -119,6 +121,9 @@ class BasicCustomFieldTest extends BaseCustomValueTest {
         ->addValue('data_type', 'String'))
       ->execute();
 
+    // Test that no new option groups have been created (these are text fields with no options)
+    $this->assertEquals($optionGroupCount, OptionGroup::get(FALSE)->selectRowCount()->execute()->count());
+
     $contactId1 = Contact::create(FALSE)
       ->addValue('first_name', 'Johann')
       ->addValue('last_name', 'Tester')
-- 
2.25.1