From aa344a478f69beb285a902e8bbf220913772c499 Mon Sep 17 00:00:00 2001
From: Andreas Hennings <andreas@dqxtech.net>
Date: Tue, 11 Feb 2014 20:41:22 +0100
Subject: [PATCH] Remove unused.

---
 CRM/Contribute/Page/ContributionPage.php | 13 ++++---------
 CRM/Utils/Request.php                    | 18 ------------------
 2 files changed, 4 insertions(+), 27 deletions(-)

diff --git a/CRM/Contribute/Page/ContributionPage.php b/CRM/Contribute/Page/ContributionPage.php
index a7df6d7ade..953f269c58 100644
--- a/CRM/Contribute/Page/ContributionPage.php
+++ b/CRM/Contribute/Page/ContributionPage.php
@@ -56,9 +56,6 @@ class CRM_Contribute_Page_ContributionPage extends CRM_Core_Page {
   private static $_configureActionLinks;
   private static $_onlineContributionLinks;
 
-  // @todo Unused private field can be safely removed.
-  private static $_links = NULL;
-
   /**
    * @var CRM_Utils_Pager
    */
@@ -322,6 +319,8 @@ class CRM_Contribute_Page_ContributionPage extends CRM_Core_Page {
     }
     elseif ($action & CRM_Core_Action::COPY) {
       // @todo Unused local variable can be safely removed.
+      // But are there any side effects of CRM_Core_Session::singleton() that we
+      // need to preserve?
       $session = CRM_Core_Session::singleton();
       CRM_Core_Session::setStatus(ts('A copy of the contribution page has been created'), ts('Successfully Copied'), 'success');
       $this->copy();
@@ -398,6 +397,8 @@ AND         cp.page_type = 'contribute'
       $this
     );
     // @todo Unused local variable can be safely removed.
+    // But are there any side effects of CRM_Utils_Request::retrieve() that we
+    // need to preserve?
     $createdId = CRM_Utils_Request::retrieve('cid', 'Positive',
       $this, FALSE, 0
     );
@@ -680,12 +681,6 @@ ORDER BY LEFT(title, 1)
         continue;
       }
 
-      // @todo Unused local variable can be safely removed.
-      $classes = array();
-      if (isset($link['class'])) {
-        $classes = $link['class'];
-      }
-
       if (empty($sectionsInfo[$sectionName])) {
         $classes = array();
         if (isset($link['class'])) {
diff --git a/CRM/Utils/Request.php b/CRM/Utils/Request.php
index 5d3779bcff..d18b764cad 100644
--- a/CRM/Utils/Request.php
+++ b/CRM/Utils/Request.php
@@ -39,24 +39,6 @@
  */
 class CRM_Utils_Request {
 
-  /**
-   * We only need one instance of this object. So we use the singleton
-   * pattern and cache the instance in this variable
-   *
-   * @var self
-   *
-   * @todo Unused private property can be safely removed.
-   */
-  static private $_singleton = NULL;
-
-  /**
-   * Constructor.
-   *
-   * @todo Empty constructor can be safely removed.
-   * @todo Class is not meant to be instantiated.
-   */
-  public function __construct() {}
-
   /**
    * Retrieve a value from the request (GET/POST/REQUEST)
    *
-- 
2.25.1