From a6fc7245b709e06e06ab7e31d746529a261f3ce9 Mon Sep 17 00:00:00 2001
From: Bradley Taylor <hello@brad-taylor.co.uk>
Date: Tue, 14 Mar 2023 19:53:00 +0000
Subject: [PATCH] [REF][PHP8.2] Tidy up properties in api_v3_CaseContactTest

---
 tests/phpunit/api/v3/CaseContactTest.php | 41 +++++++++++++-----------
 1 file changed, 23 insertions(+), 18 deletions(-)

diff --git a/tests/phpunit/api/v3/CaseContactTest.php b/tests/phpunit/api/v3/CaseContactTest.php
index 802bcdb30a..7bfc820bf8 100644
--- a/tests/phpunit/api/v3/CaseContactTest.php
+++ b/tests/phpunit/api/v3/CaseContactTest.php
@@ -6,16 +6,23 @@
  * @group headless
  */
 class api_v3_CaseContactTest extends CiviCaseTestCase {
-  protected $_params;
-  protected $_entity;
-  protected $_cid;
-  protected $_cid2;
+
+  /**
+   * @var array
+   */
+  protected $params;
+
+  /**
+   * @var int
+   */
+  protected $contactID;
+
   /**
    * Activity ID of created case.
    *
-   * @var int
+   * @var array
    */
-  protected $_caseActivityId;
+  protected $case;
 
   /**
    * Test setup for every test.
@@ -24,37 +31,35 @@ class api_v3_CaseContactTest extends CiviCaseTestCase {
    * and redirect stdin to a temporary file.
    */
   public function setUp(): void {
-    $this->_entity = 'case';
-
     parent::setUp();
 
-    $this->_cid = $this->individualCreate();
-    $this->_cid2 = $this->individualCreate([], 1);
+    $this->contactID = $this->individualCreate();
+    $contactID2 = $this->individualCreate([], 1);
 
-    $this->_case = $this->callAPISuccess('case', 'create', [
+    $this->case = $this->callAPISuccess('case', 'create', [
       'case_type_id' => $this->caseTypeId,
       'subject' => __CLASS__,
-      'contact_id' => $this->_cid,
+      'contact_id' => $this->contactID,
     ]);
 
-    $this->_params = [
-      'case_id' => $this->_case['id'],
-      'contact_id' => $this->_cid2,
+    $this->params = [
+      'case_id' => $this->case['id'],
+      'contact_id' => $contactID2,
     ];
   }
 
   public function testCaseContactGet() {
     $result = $this->callAPIAndDocument('CaseContact', 'get', [
-      'contact_id' => $this->_cid,
+      'contact_id' => $this->contactID,
     ], __FUNCTION__, __FILE__);
-    $this->assertEquals($this->_case['id'], $result['id']);
+    $this->assertEquals($this->case['id'], $result['id']);
   }
 
   /**
    * Test create function with valid parameters.
    */
   public function testCaseContactCreate() {
-    $params = $this->_params;
+    $params = $this->params;
     $result = $this->callAPIAndDocument('CaseContact', 'create', $params, __FUNCTION__, __FILE__);
     $id = $result['id'];
 
-- 
2.25.1