From a59cecb1a1ca241d109336fbca2ae52317cc65ab Mon Sep 17 00:00:00 2001 From: eileen Date: Thu, 6 Apr 2017 11:05:48 +1200 Subject: [PATCH] Add deprecation comments, CRM-19987 --- CRM/Activity/BAO/Activity.php | 3 +++ CRM/Contact/Form/Task/SMSCommon.php | 1 + tests/phpunit/CRM/Activity/BAO/ActivityTest.php | 1 + 3 files changed, 5 insertions(+) diff --git a/CRM/Activity/BAO/Activity.php b/CRM/Activity/BAO/Activity.php index 05e5d09de9..52d192476f 100644 --- a/CRM/Activity/BAO/Activity.php +++ b/CRM/Activity/BAO/Activity.php @@ -1705,6 +1705,8 @@ LEFT JOIN civicrm_activity_contact src ON (src.activity_id = ac.activity_id AND } /** + * @deprecated - use the api instead. + * * Get the Activities of a target contact. * * @param int $contactId @@ -1714,6 +1716,7 @@ LEFT JOIN civicrm_activity_contact src ON (src.activity_id = ac.activity_id AND * array of activity fields */ public static function getContactActivity($contactId) { + // @todo remove this function entirely. $activities = array(); $activityContacts = CRM_Core_OptionGroup::values('activity_contacts', FALSE, FALSE, FALSE, NULL, 'name'); $sourceID = CRM_Utils_Array::key('Activity Source', $activityContacts); diff --git a/CRM/Contact/Form/Task/SMSCommon.php b/CRM/Contact/Form/Task/SMSCommon.php index 6ab8bc815b..a4ab022d26 100644 --- a/CRM/Contact/Form/Task/SMSCommon.php +++ b/CRM/Contact/Form/Task/SMSCommon.php @@ -198,6 +198,7 @@ class CRM_Contact_Form_Task_SMSCommon { if (CRM_Utils_System::getClassName($form) == 'CRM_Activity_Form_Task_SMS') { //to check for "if the contact id belongs to a specified activity type" + // @todo use the api instead - function is deprecated. $actDetails = CRM_Activity_BAO_Activity::getContactActivity($contactId); if (self::RECIEVED_SMS_ACTIVITY_SUBJECT != CRM_Utils_Array::retrieveValueRecursive($actDetails, 'subject') diff --git a/tests/phpunit/CRM/Activity/BAO/ActivityTest.php b/tests/phpunit/CRM/Activity/BAO/ActivityTest.php index 006307aa80..06cd104a3e 100644 --- a/tests/phpunit/CRM/Activity/BAO/ActivityTest.php +++ b/tests/phpunit/CRM/Activity/BAO/ActivityTest.php @@ -81,6 +81,7 @@ class CRM_Activity_BAO_ActivityTest extends CiviUnitTestCase { 'subject', 'Database check for created activity.' ); + // @todo - remove this deprecated functions $activities = CRM_Activity_BAO_Activity::getContactActivity($targetContactId); $this->assertEquals($activities[$activityId]['subject'], 'Scheduling Meeting', 'Verify activity subject is correct.'); -- 2.25.1