From a44a9f0e36a03103b3679e2ca5b2afae9bbf10b1 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Fri, 16 Jul 2021 17:55:57 +1200 Subject: [PATCH] [Ref] Remove never-passed parameter this function is called from only one place & it does not pass in financialTrxnValues --- CRM/Contribute/BAO/Contribution.php | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index 7dab1582be..a823b1aa97 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -3376,12 +3376,10 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac * Contribution object, line item array and params for trxn. * * - * @param array $financialTrxnValues - * * @return null|\CRM_Core_BAO_FinancialTrxn */ - public static function recordFinancialAccounts(&$params, $financialTrxnValues = NULL) { - $skipRecords = $update = $return = FALSE; + public static function recordFinancialAccounts(&$params) { + $skipRecords = $return = FALSE; $isUpdate = !empty($params['prevContribution']); $additionalParticipantId = []; @@ -3491,10 +3489,6 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac $trxnParams['payment_processor_id'] = $params['payment_processor']; } - // consider external values passed for recording transaction entry - if (!empty($financialTrxnValues)) { - $trxnParams = array_merge($trxnParams, $financialTrxnValues); - } if (empty($trxnParams['payment_processor_id'])) { unset($trxnParams['payment_processor_id']); } -- 2.25.1