From a26a6848f421d28ed1666699fc77c42e9dfeb6cb Mon Sep 17 00:00:00 2001
From: Rich Lott / Artful Robot <forums@artfulrobot.uk>
Date: Fri, 9 Oct 2020 09:26:27 +0100
Subject: [PATCH] Add test for Activity::update()

---
 tests/phpunit/api/v4/Entity/ActivityTest.php | 103 +++++++++++++++++++
 1 file changed, 103 insertions(+)
 create mode 100644 tests/phpunit/api/v4/Entity/ActivityTest.php

diff --git a/tests/phpunit/api/v4/Entity/ActivityTest.php b/tests/phpunit/api/v4/Entity/ActivityTest.php
new file mode 100644
index 0000000000..cf09b4e109
--- /dev/null
+++ b/tests/phpunit/api/v4/Entity/ActivityTest.php
@@ -0,0 +1,103 @@
+<?php
+
+/*
+ +--------------------------------------------------------------------+
+ | Copyright CiviCRM LLC. All rights reserved.                        |
+ |                                                                    |
+ | This work is published under the GNU AGPLv3 license with some      |
+ | permitted exceptions and without any warranty. For full license    |
+ | and copyright information, see https://civicrm.org/licensing       |
+ +--------------------------------------------------------------------+
+ */
+
+/**
+ *
+ * @package CRM
+ * @copyright CiviCRM LLC https://civicrm.org/licensing
+ */
+
+namespace api\v4\Entity;
+
+use Civi\Api4\Contact;
+use api\v4\UnitTestCase;
+use Civi\Api4\Activity;
+use Civi\Api4\ActivityContact;
+use Civi\Test\TransactionalInterface;
+
+/**
+ * Assert that updating an activity does not affect the targets.
+ *
+ * This test was written specifically to test
+ * https://lab.civicrm.org/dev/core/-/issues/1428
+ *
+ * @group headless
+ */
+class ActivityTest extends UnitTestCase implements TransactionalInterface {
+
+  public function testActivityUpdate() {
+
+    $meetingActivityTypeID = \Civi\Api4\OptionValue::get()
+      ->addSelect('value')
+      ->addWhere('option_group_id:name', '=', 'activity_type')
+      ->addWhere('name', '=', 'Meeting')
+      ->execute()->first()['value'];
+
+    $domainContactID = \CRM_Core_BAO_Domain::getDomain()->contact_id;
+    $c1 = Contact::create(FALSE)->addValue('first_name', '1')->execute()->first()['id'];
+    $c2 = Contact::create(FALSE)->addValue('first_name', '2')->execute()->first()['id'];
+
+    $activityID = Activity::create(FALSE)
+      ->setValues([
+        'target_contact_id'   => [$c1],
+        'assignee_contact_id' => [$c2],
+        'activity_type_id'    => $meetingActivityTypeID,
+        'source_contact_id'   => $domainContactID,
+        'subject'             => 'test activity',
+      ])->execute()->first()['id'];
+
+    // Activity create does not return a full record, so get the ID then do another get call...
+    $activity = Activity::get(FALSE)
+      ->addSelect('id', 'subject', 'activity_type_id')
+      ->addWhere('id', '=', $activityID)
+      ->execute()->first();
+    $this->assertEquals($meetingActivityTypeID, $activity['activity_type_id']);
+    $this->assertEquals('test activity', $activity['subject']);
+
+    // Now check we have the correct target and assignees.
+    $activityContacts = ActivityContact::get(FALSE)
+      ->addWhere('activity_id', '=', $activityID)
+      ->execute()
+      ->indexBy('contact_id')->column('record_type_id');
+
+    // 1 is assignee
+    // 2 is added
+    // 3 is target/with
+    $expectedActivityContacts = [$c1 => 3, $c2 => 1, $domainContactID => 2];
+    ksort($expectedActivityContacts);
+    ksort($activityContacts);
+    $this->assertEquals($expectedActivityContacts, $activityContacts, "ActivityContacts not as expected.");
+
+    // Test we can update the activity.
+    Activity::update(FALSE)
+      ->addWhere('id', '=', $activityID)
+      ->addValue('subject', 'updated subject')
+      ->execute();
+
+    // Repeat the tests.
+    $activity = Activity::get(FALSE)
+      ->addSelect('id', 'subject', 'activity_type_id')
+      ->addWhere('id', '=', $activityID)
+      ->execute()->first();
+    $this->assertEquals($meetingActivityTypeID, $activity['activity_type_id']);
+    $this->assertEquals('updated subject', $activity['subject'], "Activity subject was not updated correctly by Activity::update.");
+
+    // Now check we have the correct target and assignees.
+    $activityContacts = ActivityContact::get(FALSE)
+      ->addWhere('activity_id', '=', $activityID)
+      ->execute()
+      ->indexBy('contact_id')->column('record_type_id');
+    ksort($activityContacts);
+    $this->assertEquals($expectedActivityContacts, $activityContacts, "ActivityContacts not as expected after update.");
+  }
+
+}
-- 
2.25.1