From a02a78c94e808e30969b6f0048fbc0679de74660 Mon Sep 17 00:00:00 2001
From: Ahed <ahed@compucorp.co.uk>
Date: Fri, 2 Jun 2023 11:47:27 +0300
Subject: [PATCH] dev/core#4333 Set default created_id for case and activity
 Attachments

---
 CRM/Core/BAO/File.php                   |   3 +
 tests/phpunit/CRM/Core/BAO/FileTest.php | 151 ++++++++++++++++++++++++
 2 files changed, 154 insertions(+)
 create mode 100644 tests/phpunit/CRM/Core/BAO/FileTest.php

diff --git a/CRM/Core/BAO/File.php b/CRM/Core/BAO/File.php
index 9d8cb0ae30..1786f71c8a 100644
--- a/CRM/Core/BAO/File.php
+++ b/CRM/Core/BAO/File.php
@@ -149,6 +149,9 @@ class CRM_Core_BAO_File extends CRM_Core_DAO_File {
       $fileDAO->id = $dao->cfID;
       unlink($directoryName . DIRECTORY_SEPARATOR . $dao->uri);
     }
+    elseif (empty($fileParams['created_id'])) {
+      $fileDAO->created_id = CRM_Core_Session::getLoggedInContactID();
+    }
 
     if (!empty($fileParams)) {
       $fileDAO->copyValues($fileParams);
diff --git a/tests/phpunit/CRM/Core/BAO/FileTest.php b/tests/phpunit/CRM/Core/BAO/FileTest.php
new file mode 100644
index 0000000000..e883347105
--- /dev/null
+++ b/tests/phpunit/CRM/Core/BAO/FileTest.php
@@ -0,0 +1,151 @@
+<?php
+
+use Civi\Api4\Activity;
+
+/**
+ * Class CRM_Core_BAO_FileTest
+ *
+ * @group headless
+ */
+class CRM_Core_BAO_FileTest extends CiviUnitTestCase {
+  protected $sampleFile = NULL;
+
+  protected function setUp(): void {
+    parent::setUp();
+
+    $this->sampleFile = sys_get_temp_dir() . '/file.txt';
+    file_put_contents($this->sampleFile, 'This comes from a file');
+  }
+
+  /**
+   * Clean up after test.
+   */
+  public function tearDown(): void {
+    $this->quickCleanup(['civicrm_activity', 'civicrm_file', 'civicrm_entity_file'], TRUE);
+    parent::tearDown();
+  }
+
+  /**
+   * Test creating a file.
+   */
+  public function testCreateFile(): void {
+    $file = $this->createFile();
+
+    $this->assertDBNotNull('CRM_Core_DAO_File', $file->id, 'created_id', 'id',
+      'Database check for created File.'
+    );
+
+    $fields = [
+      'id' => $file->id,
+      'mime_type' => 'image/jpg',
+      'uri' => 'fake_file.jpg',
+      'description' => 'Edited fake file',
+    ];
+    CRM_Core_BAO_File::create($fields);
+
+    $this->assertDBNotNull('CRM_Core_DAO_File', $fields['mime_type'], 'id', 'mime_type', 'Database check for edited File.');
+    $this->assertDBNotNull('CRM_Core_DAO_File', $fields['uri'], 'id', 'uri', 'Database check for edited File.');
+  }
+
+  /**
+   * Test creating a file using the filePostProcess method.
+   */
+  public function testCreateFileUsingPostProcess(): void {
+    $activity = $this->createActivity();
+
+    $path = $this->sampleFile;
+    $params = [
+      'path' => $path,
+      'file_type_id' => NULL,
+      'entity_table' => 'civicrm_activity',
+      'entity_id' => $activity['id'],
+      'entity_subtype' => NULL,
+      'overwrite' => TRUE,
+      'file_params' => [
+        'uri' => $path,
+        'type' => 'text/plain',
+        'location' => $path,
+        'upload_date' => '20230602075923',
+        'description' => '',
+        'tag' => [],
+        'attachment_taglist' => [],
+      ],
+      'upload_name' => 'uploadFile',
+      'mime_type' => 'text/plain',
+    ];
+    CRM_Core_BAO_File::filePostProcess(...array_values($params));
+
+    $this->assertDBNotNull('CRM_Core_DAO_File', 'file.txt', 'id', 'uri', 'Database check for created File.');
+  }
+
+  /**
+   * Test creating a file using the filePostProcess method as the logged in user.
+   */
+  public function testCreateFileUsingPostProcessAsTheLoggedInUser(): void {
+    $loggedInUser = $this->createLoggedInUser();
+    $activity = $this->createActivity();
+
+    $path = $this->sampleFile;
+    $params = [
+      'path' => $path,
+      'file_type_id' => NULL,
+      'entity_table' => 'civicrm_activity',
+      'entity_id' => $activity['id'],
+      'entity_subtype' => NULL,
+      'overwrite' => TRUE,
+      'file_params' => [
+        'uri' => $path,
+        'type' => 'text/plain',
+        'location' => $path,
+        'upload_date' => '20230602075923',
+        'description' => '',
+        'tag' => [],
+        'attachment_taglist' => [],
+      ],
+      'upload_name' => 'uploadFile',
+      'mime_type' => 'text/plain',
+    ];
+    CRM_Core_BAO_File::filePostProcess(...array_values($params));
+
+    $this->assertDBNotNull('CRM_Core_DAO_File', $loggedInUser, 'id', 'created_id', 'Database check for created File.');
+  }
+
+  /**
+   * Create a file
+   *
+   * @return array
+   */
+  protected function createFile() {
+    $contactId = $this->individualCreate();
+
+    $fields = [
+      'file_type_id' => NULL,
+      'mime_type' => 'image/png',
+      'uri' => 'fake_file.png',
+      'document' => NULL,
+      'description' => 'Fake file',
+      'upload_date' => '2023-05-10 15:00:00',
+      'created_id' => $contactId,
+    ];
+    $field = CRM_Core_BAO_File::create($fields);
+    return $field;
+  }
+
+  /**
+   * Create an activity
+   *
+   * @return array
+   */
+  protected function createActivity() {
+    $contactId = $this->individualCreate();
+    $activity = Activity::create()
+      ->addValue('source_contact_id', $contactId)
+      ->addValue('subject', 'Scheduling Meeting')
+      ->addValue('activity_type_id', 1)
+      ->execute()
+      ->single();
+
+    return $activity;
+  }
+
+}
-- 
2.25.1