From 9fa6bb0b4617e8f887cd26c50fb1ea52931a48e8 Mon Sep 17 00:00:00 2001
From: Tim Otten <totten@civicrm.org>
Date: Wed, 2 Jun 2021 13:27:16 -0700
Subject: [PATCH] dev/translation#67 - Add titles to XML+DAO

---
 CRM/Core/DAO/Translation.php    | 25 ++++++++++++++-----------
 xml/schema/Core/Translation.xml |  7 +++++++
 2 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/CRM/Core/DAO/Translation.php b/CRM/Core/DAO/Translation.php
index 91fdd010ae..84bd641b7a 100644
--- a/CRM/Core/DAO/Translation.php
+++ b/CRM/Core/DAO/Translation.php
@@ -6,7 +6,7 @@
  *
  * Generated from xml/schema/CRM/Core/Translation.xml
  * DO NOT EDIT.  Generated by CRM_Core_CodeGen
- * (GenCodeChecksum:750397fc8532cb5f28bd1ff507bb3dd2)
+ * (GenCodeChecksum:9c290a244c0efde76b4e0cd83a069b2b)
  */
 
 /**
@@ -123,12 +123,13 @@ class CRM_Core_DAO_Translation extends CRM_Core_DAO {
         'id' => [
           'name' => 'id',
           'type' => CRM_Utils_Type::T_INT,
+          'title' => ts('Translated String ID'),
           'description' => ts('Unique String ID'),
           'required' => TRUE,
           'where' => 'civicrm_translation.id',
           'table_name' => 'civicrm_translation',
           'entity' => 'Translation',
-          'bao' => 'CRM_Core_DAO_Translation',
+          'bao' => 'CRM_Core_BAO_Translation',
           'localizable' => 0,
           'readonly' => TRUE,
           'add' => '5.39',
@@ -136,7 +137,7 @@ class CRM_Core_DAO_Translation extends CRM_Core_DAO {
         'entity_table' => [
           'name' => 'entity_table',
           'type' => CRM_Utils_Type::T_STRING,
-          'title' => ts('Entity Table'),
+          'title' => ts('Translated Entity'),
           'description' => ts('Table where referenced item is stored'),
           'required' => TRUE,
           'maxlength' => 64,
@@ -144,7 +145,7 @@ class CRM_Core_DAO_Translation extends CRM_Core_DAO {
           'where' => 'civicrm_translation.entity_table',
           'table_name' => 'civicrm_translation',
           'entity' => 'Translation',
-          'bao' => 'CRM_Core_DAO_Translation',
+          'bao' => 'CRM_Core_BAO_Translation',
           'localizable' => 0,
           'pseudoconstant' => [
             'callback' => 'CRM_Core_BAO_Translation::getEntityTables',
@@ -154,7 +155,7 @@ class CRM_Core_DAO_Translation extends CRM_Core_DAO {
         'entity_field' => [
           'name' => 'entity_field',
           'type' => CRM_Utils_Type::T_STRING,
-          'title' => ts('Entity Field'),
+          'title' => ts('Translated Field'),
           'description' => ts('Field where referenced item is stored'),
           'required' => TRUE,
           'maxlength' => 64,
@@ -162,7 +163,7 @@ class CRM_Core_DAO_Translation extends CRM_Core_DAO {
           'where' => 'civicrm_translation.entity_field',
           'table_name' => 'civicrm_translation',
           'entity' => 'Translation',
-          'bao' => 'CRM_Core_DAO_Translation',
+          'bao' => 'CRM_Core_BAO_Translation',
           'localizable' => 0,
           'pseudoconstant' => [
             'callback' => 'CRM_Core_BAO_Translation::getEntityFields',
@@ -172,12 +173,13 @@ class CRM_Core_DAO_Translation extends CRM_Core_DAO {
         'entity_id' => [
           'name' => 'entity_id',
           'type' => CRM_Utils_Type::T_INT,
+          'title' => ts('Translated Entity ID'),
           'description' => ts('ID of the relevant entity.'),
           'required' => TRUE,
           'where' => 'civicrm_translation.entity_id',
           'table_name' => 'civicrm_translation',
           'entity' => 'Translation',
-          'bao' => 'CRM_Core_DAO_Translation',
+          'bao' => 'CRM_Core_BAO_Translation',
           'localizable' => 0,
           'add' => '5.39',
         ],
@@ -192,7 +194,7 @@ class CRM_Core_DAO_Translation extends CRM_Core_DAO {
           'where' => 'civicrm_translation.language',
           'table_name' => 'civicrm_translation',
           'entity' => 'Translation',
-          'bao' => 'CRM_Core_DAO_Translation',
+          'bao' => 'CRM_Core_BAO_Translation',
           'localizable' => 0,
           'html' => [
             'type' => 'Select',
@@ -207,13 +209,14 @@ class CRM_Core_DAO_Translation extends CRM_Core_DAO {
         'status_id' => [
           'name' => 'status_id',
           'type' => CRM_Utils_Type::T_INT,
+          'title' => ts('Status'),
           'description' => ts('Specify whether the string is active, draft, etc'),
           'required' => TRUE,
           'where' => 'civicrm_translation.status_id',
           'default' => '1',
           'table_name' => 'civicrm_translation',
           'entity' => 'Translation',
-          'bao' => 'CRM_Core_DAO_Translation',
+          'bao' => 'CRM_Core_BAO_Translation',
           'localizable' => 0,
           'pseudoconstant' => [
             'callback' => 'CRM_Core_BAO_Translation::getStatuses',
@@ -223,13 +226,13 @@ class CRM_Core_DAO_Translation extends CRM_Core_DAO {
         'string' => [
           'name' => 'string',
           'type' => CRM_Utils_Type::T_LONGTEXT,
-          'title' => ts('String'),
+          'title' => ts('Translated String'),
           'description' => ts('Translated string'),
           'required' => TRUE,
           'where' => 'civicrm_translation.string',
           'table_name' => 'civicrm_translation',
           'entity' => 'Translation',
-          'bao' => 'CRM_Core_DAO_Translation',
+          'bao' => 'CRM_Core_BAO_Translation',
           'localizable' => 0,
           'add' => '5.39',
         ],
diff --git a/xml/schema/Core/Translation.xml b/xml/schema/Core/Translation.xml
index 8f35723b6f..51152be0c0 100644
--- a/xml/schema/Core/Translation.xml
+++ b/xml/schema/Core/Translation.xml
@@ -13,6 +13,7 @@
   <field>
     <add>5.39</add>
     <name>id</name>
+    <title>Translated String ID</title>
     <type>int unsigned</type>
     <required>true</required>
     <comment>Unique String ID</comment>
@@ -25,6 +26,7 @@
   <field>
     <add>5.39</add>
     <name>entity_table</name>
+    <title>Translated Entity</title>
     <type>varchar</type>
     <length>64</length>
     <required>true</required>
@@ -37,6 +39,7 @@
   <field>
     <add>5.39</add>
     <name>entity_field</name>
+    <title>Translated Field</title>
     <type>varchar</type>
     <length>64</length>
     <required>true</required>
@@ -49,6 +52,7 @@
   <field>
     <add>5.39</add>
     <name>entity_id</name>
+    <title>Translated Entity ID</title>
     <type>int</type>
     <length>64</length>
     <required>true</required>
@@ -58,6 +62,7 @@
   <field>
     <add>5.39</add>
     <name>language</name>
+    <title>Language</title>
     <type>varchar</type>
     <length>5</length>
     <required>true</required>
@@ -76,6 +81,7 @@
     <add>5.39</add>
     <name>status_id</name>
     <type>tinyint</type>
+    <title>Status</title>
     <length>3</length>
     <default>1</default>
     <required>true</required>
@@ -87,6 +93,7 @@
 
   <field>
     <add>5.39</add>
+    <title>Translated String</title>
     <name>string</name>
     <type>longtext</type>
     <required>true</required>
-- 
2.25.1