From 9ce8301b5cd55b119d69b41920dc434d1096cfc3 Mon Sep 17 00:00:00 2001
From: eileen <emcnaughton@wikimedia.org>
Date: Wed, 16 Sep 2020 14:44:40 +1200
Subject: [PATCH] dev/core#2043 remove pass-by-ref

Also shortening of if clause
---
 CRM/Core/BAO/Block.php | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/CRM/Core/BAO/Block.php b/CRM/Core/BAO/Block.php
index 0689b0a495..4014dbb17d 100644
--- a/CRM/Core/BAO/Block.php
+++ b/CRM/Core/BAO/Block.php
@@ -131,20 +131,15 @@ class CRM_Core_BAO_Block {
    * Check if the current block exits.
    *
    * @param string $blockName
-   *   Bloack name.
+   *   Block name.
    * @param array $params
-   *   Associated array of submitted fields.
+   *   Array of submitted fields.
    *
    * @return bool
-   *   true if the block exits, otherwise false
+   *   true if the block is in the params and is an array
    */
-  public static function blockExists($blockName, &$params) {
-    // return if no data present
-    if (empty($params[$blockName]) || !is_array($params[$blockName])) {
-      return FALSE;
-    }
-
-    return TRUE;
+  public static function blockExists($blockName, $params) {
+    return !empty($params[$blockName]) && is_array($params[$blockName]);
   }
 
   /**
-- 
2.25.1