From 9a1b1948b37f905819085025eef67b8bc37484a9 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Tue, 29 Apr 2014 09:48:59 -0700 Subject: [PATCH] more comment fixes --- CRM/Core/DAO.php | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/CRM/Core/DAO.php b/CRM/Core/DAO.php index 7596dee47d..0879ab6cc2 100644 --- a/CRM/Core/DAO.php +++ b/CRM/Core/DAO.php @@ -1804,8 +1804,10 @@ EOS; * The overriding function will generally call the lower-level CRM_Core_PseudoConstant::get * * @param string $fieldName - * @param string $context: @see CRM_Core_DAO::buildOptionsContext - * @param array $props: whatever is known about this bao object + * @param string $context : @see CRM_Core_DAO::buildOptionsContext + * @param array $props : whatever is known about this bao object + * + * @return Array|bool */ public static function buildOptions($fieldName, $context = NULL, $props = array()) { // If a given bao does not override this function @@ -1882,22 +1884,25 @@ EOS; * $field => array('LIKE' => array('%me%)) * etc * - * @param $fieldname string name of fields + * @param $fieldName * @param $filter array filter to be applied indexed by operator * @param $type String type of field (not actually used - nor in api @todo ) * @param $alias String alternative field name ('as') @todo- not actually used * @param bool $returnSanitisedArray return a sanitised array instead of a clause * this is primarily so we can add filters @ the api level to the Query object based fields - * @todo a better solutution would be for the query object to apply these filters based on the + * + * @throws Exception + * @internal param string $fieldname name of fields + * @todo a better solutution would be for the query object to apply these filters based on the * api supported format (but we don't want to risk breakage in alpha stage & query class is scary - * @todo @time of writing only IN & NOT IN are supported for the array style syntax (as test is + * @todo @time of writing only IN & NOT IN are supported for the array style syntax (as test is * required to extend further & it may be the comments per above should be implemented. It may be * preferable to not double-banger the return context next refactor of this - but keeping the attention * in one place has some advantages as we try to extend this format * - * @return NULL|string|array a string is returned if $returnSanitisedArray is not set, otherwise and Array or NULL + * @return NULL|string|array a string is returned if $returnSanitisedArray is not set, otherwise and Array or NULL * depending on whether it is supported as yet - **/ + */ public static function createSQLFilter($fieldName, $filter, $type, $alias = NULL, $returnSanitisedArray = FALSE) { // http://issues.civicrm.org/jira/browse/CRM-9150 - stick with 'simple' operators for now // support for other syntaxes is discussed in ticket but being put off for now @@ -1977,7 +1982,11 @@ EOS; * strings that meet various criteria. * * @param string $string - the string to be shortened - * @param int $length - the max length of the string + * @param int $length - the max length of the string + * + * @param bool $makeRandom + * + * @return string */ public static function shortenSQLName($string, $length = 60, $makeRandom = FALSE) { // early return for strings that meet the requirements -- 2.25.1