From 981e0d0bfbc03d7ad1e63ab3ef74ea94229f49ac Mon Sep 17 00:00:00 2001 From: eileen Date: Sat, 15 Jun 2019 05:43:47 -0400 Subject: [PATCH] Fix instance of NULL contamination --- CRM/Contribute/BAO/Contribution.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index e89776de28..3765561e3e 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -317,7 +317,7 @@ class CRM_Contribute_BAO_Contribution extends CRM_Contribute_DAO_Contribution { * @return CRM_Contribute_BAO_Contribution|null * The found object or null */ - public static function getValues($params, &$values, &$ids) { + public static function getValues($params, &$values = [], &$ids = []) { if (empty($params)) { return NULL; } @@ -4493,8 +4493,7 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac $primaryContributionID = isset($contribution->id) ? $contribution->id : $objects['first_contribution']->id; // The previous details are used when calculating line items so keep it before any code that 'does something' if (!empty($contribution->id)) { - $input['prevContribution'] = CRM_Contribute_BAO_Contribution::getValues(['id' => $contribution->id], - CRM_Core_DAO::$_nullArray, CRM_Core_DAO::$_nullArray); + $input['prevContribution'] = CRM_Contribute_BAO_Contribution::getValues(['id' => $contribution->id]); } $inputContributionWhiteList = [ 'fee_amount', -- 2.25.1