From 966a1362327c8ed8d5455879252b21ab528df9a8 Mon Sep 17 00:00:00 2001
From: Andrew Hunt <andrew@aghstrategies.com>
Date: Thu, 28 Mar 2013 15:49:48 -0400
Subject: [PATCH] made it more concise

---
 CRM/Admin/Form/Setting/Mail.php | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/CRM/Admin/Form/Setting/Mail.php b/CRM/Admin/Form/Setting/Mail.php
index 40f7aa0c30..82f9f26c19 100644
--- a/CRM/Admin/Form/Setting/Mail.php
+++ b/CRM/Admin/Form/Setting/Mail.php
@@ -70,15 +70,14 @@ class CRM_Admin_Form_Setting_Mail extends CRM_Admin_Form_Setting {
   static function formRule($fields) {
     $errors = array();
 
-    if (CRM_Utils_Array::value('mailerJobSize', $fields) < 1000
-      && CRM_Utils_Array::value('mailerJobSize', $fields) > 0) {
-      $errors['mailerJobSize'] = ts('The job size must be at least 1000 or set to 0 (unlimited).');
-    }
-    elseif (CRM_Utils_Array::value('mailerJobSize', $fields) <
-      CRM_Utils_Array::value('mailerBatchLimit', $fields)
-      && CRM_Utils_Array::value('mailerBatchLimit', $fields) > 0
-      && CRM_Utils_Array::value('mailerJobSize', $fields) > 0) {
-      $errors['mailerJobSize'] = ts('A job size smaller than the batch limit will negate the effect of the batch limit.');
+    if (CRM_Utils_Array::value('mailerJobSize', $fields) > 0) {
+      if (CRM_Utils_Array::value('mailerJobSize', $fields) < 1000) {
+        $errors['mailerJobSize'] = ts('The job size must be at least 1000 or set to 0 (unlimited).');
+      }
+      elseif (CRM_Utils_Array::value('mailerJobSize', $fields) <
+        CRM_Utils_Array::value('mailerBatchLimit', $fields)) {
+        $errors['mailerJobSize'] = ts('A job size smaller than the batch limit will negate the effect of the batch limit.');
+      }
     }
     
     return empty($errors) ? TRUE : $errors;
-- 
2.25.1