From 9416187d3c913e3b6ebd5212deedc69bcfbeebb2 Mon Sep 17 00:00:00 2001 From: Tim Otten Date: Wed, 1 Jun 2022 13:51:06 -0700 Subject: [PATCH] (REF) Extensions - Extract method to build upgrade queue I was slightly concerned that building a queue under a different there are two risks, although I don't think either is very big: 1. That someone references the queue by name during the building process. However, it wouldn't make much sense from a DX POV (given how "Upgrader" classes are generally written), and I can't any references to `QUEUE_NAME` or `ext-upgrade` in `universe` 2. That someone generates queue tasks with `weight`s that somehow clash with the `weight`s in core-queue. However, this also doesn't make much sense from a DX POV (given how "upgrader" classes are generally written). --- CRM/Extension/Upgrades.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CRM/Extension/Upgrades.php b/CRM/Extension/Upgrades.php index 6d5991fa55..66588d5f8f 100644 --- a/CRM/Extension/Upgrades.php +++ b/CRM/Extension/Upgrades.php @@ -61,7 +61,15 @@ class CRM_Extension_Upgrades { 'name' => self::QUEUE_NAME, 'reset' => TRUE, ]); + return static::fillQueue($queue); + } + /** + * @param \CRM_Queue_Queue $queue + * + * @return \CRM_Queue_Queue + */ + public static function fillQueue(CRM_Queue_Queue $queue): CRM_Queue_Queue { foreach (self::getActiveUpgraders() as $upgrader) { /** @var \CRM_Extension_Upgrader_Interface $upgrader */ $upgrader->notify('upgrade', ['enqueue', $queue]); -- 2.25.1