From 92eacb41a2a8a3b2c337b1f5eaa35c7030eafe17 Mon Sep 17 00:00:00 2001 From: eileen Date: Wed, 25 Mar 2020 17:40:59 +1300 Subject: [PATCH] [REF] Remove & from before variable I couldn't see how this & could do anything useful given it's an object & testing shows the form is unchanged --- CRM/Activity/Form/Activity.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CRM/Activity/Form/Activity.php b/CRM/Activity/Form/Activity.php index 6f1885e7bd..131daeb74a 100644 --- a/CRM/Activity/Form/Activity.php +++ b/CRM/Activity/Form/Activity.php @@ -227,6 +227,8 @@ class CRM_Activity_Form_Activity extends CRM_Contact_Form_Task { /** * Build the form object. + * + * @throws \CRM_Core_Exception */ public function preProcess() { CRM_Core_Form_RecurringEntity::preProcess('civicrm_activity'); @@ -629,7 +631,7 @@ class CRM_Activity_Form_Activity extends CRM_Contact_Form_Task { // Enable form element (ActivityLinks sets this true). $this->assign('suppressForm', FALSE); - $element = &$this->add('select', 'activity_type_id', ts('Activity Type'), + $element = $this->add('select', 'activity_type_id', ts('Activity Type'), ['' => '- ' . ts('select') . ' -'] + $this->_fields['followup_activity_type_id']['attributes'], FALSE, [ 'onchange' => "CRM.buildCustomData( 'Activity', this.value, false, false, false, false, false, false, {$this->_currentlyViewedContactId});", -- 2.25.1