From 92bec5a5a4c08efb0014e6bfc5c8306727c4ec92 Mon Sep 17 00:00:00 2001
From: eileen <emcnaughton@wikimedia.org>
Date: Sat, 31 Oct 2020 12:23:00 +1300
Subject: [PATCH] Hack away at false negative test fails

---
 .../api/v4/Service/TestCreationParameterProvider.php        | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/phpunit/api/v4/Service/TestCreationParameterProvider.php b/tests/phpunit/api/v4/Service/TestCreationParameterProvider.php
index da96cec0c4..ee0138a946 100644
--- a/tests/phpunit/api/v4/Service/TestCreationParameterProvider.php
+++ b/tests/phpunit/api/v4/Service/TestCreationParameterProvider.php
@@ -53,6 +53,12 @@ class TestCreationParameterProvider {
     $requiredParams = [];
     foreach ($requiredFields as $requiredField) {
       $value = $this->getRequiredValue($requiredField);
+      if ($entity === 'UFField' && $requiredField->getName() === 'field_name') {
+        // This is a ruthless hack to avoid a unique constraint - but
+        // it's also a test class & hard to care enough to do something
+        // better
+        $value = 'activity_campaign_id';
+      }
       $requiredParams[$requiredField->getName()] = $value;
     }
 
-- 
2.25.1