From 902d0e66ed6a3adb0f3855981e9e1020551f7eab Mon Sep 17 00:00:00 2001
From: Dave Greenberg <dave@civicrm.org>
Date: Tue, 20 May 2014 16:52:37 -0700
Subject: [PATCH 1/1] CRM-14716 - Change default Visibility for Mailings for
 Public Pages.

----------------------------------------
* CRM-14716:
  https://issues.civicrm.org/jira/browse/CRM-14716
---
 CRM/Mailing/BAO/Mailing.php    | 2 +-
 CRM/Mailing/Form/Settings.php  | 5 +++++
 xml/schema/Mailing/Mailing.xml | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/CRM/Mailing/BAO/Mailing.php b/CRM/Mailing/BAO/Mailing.php
index 4495d2d3c2..b425e5f077 100644
--- a/CRM/Mailing/BAO/Mailing.php
+++ b/CRM/Mailing/BAO/Mailing.php
@@ -1528,7 +1528,7 @@ ORDER BY   civicrm_email.is_bulkmail DESC
         'forward_replies' => FALSE,
         'open_tracking'   => TRUE,
         'url_tracking'    => TRUE,
-        'visibility'      => 'User and User Admin Only',
+        'visibility'      => 'Public Pages',
         'replyto_email'   => $domain_email,
         'header_id'       => CRM_Mailing_PseudoConstant::defaultComponent('header_id', ''),
         'footer_id'       => CRM_Mailing_PseudoConstant::defaultComponent('footer_id', ''),
diff --git a/CRM/Mailing/Form/Settings.php b/CRM/Mailing/Form/Settings.php
index 15b58f1742..59825fb6c6 100644
--- a/CRM/Mailing/Form/Settings.php
+++ b/CRM/Mailing/Form/Settings.php
@@ -66,6 +66,10 @@ class CRM_Mailing_Form_Settings extends CRM_Core_Form {
    */
   function setDefaultValues() {
     $mailingID = CRM_Utils_Request::retrieve('mid', 'Integer', $this, FALSE, NULL);
+    // CRM-
+    if (!$mailingID) {
+      $mailingID = $this->get('mailing_id');
+    }
     $count = $this->get('count');
     $this->assign('count', $count);
     $defaults = array();
@@ -92,6 +96,7 @@ class CRM_Mailing_Form_Settings extends CRM_Core_Form {
       $dao->storeValues($dao, $defaults);
       $defaults['visibility'] = $dao->visibility;
     }
+    
     return $defaults;
   }
 
diff --git a/xml/schema/Mailing/Mailing.xml b/xml/schema/Mailing/Mailing.xml
index b926f1ea06..bf28665456 100644
--- a/xml/schema/Mailing/Mailing.xml
+++ b/xml/schema/Mailing/Mailing.xml
@@ -300,7 +300,7 @@
        <name>visibility</name>
        <type>varchar</type>
        <length>40</length>
-       <default>'User and User Admin Only'</default>
+       <default>'Public Pages'</default>
        <comment>In what context(s) is the mailing contents visible (online viewing)</comment>
        <pseudoconstant>
          <callback>CRM_Core_SelectValues::groupVisibility</callback>
-- 
2.25.1