From 8de8eb194345cf7a7f7ff923385cd257a32d0927 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Tue, 12 Apr 2022 07:53:08 +1200 Subject: [PATCH] Reduce use of reference Reference does not make sense for objects. assign_by_ref does not make sense when not used again in the function or returned in a reffy kinda way --- CRM/Core/BAO/CustomGroup.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CRM/Core/BAO/CustomGroup.php b/CRM/Core/BAO/CustomGroup.php index 0988048481..1dfa5697e0 100644 --- a/CRM/Core/BAO/CustomGroup.php +++ b/CRM/Core/BAO/CustomGroup.php @@ -1896,7 +1896,7 @@ SELECT IF( EXISTS(SELECT name FROM civicrm_contact_type WHERE name like %1), 1, * @return array|int * @throws \CRM_Core_Exception */ - public static function buildCustomDataView(&$form, $groupTree, $returnCount = FALSE, $gID = NULL, $prefix = NULL, $customValueId = NULL, $entityId = NULL, $checkEditPermission = FALSE) { + public static function buildCustomDataView($form, $groupTree, $returnCount = FALSE, $gID = NULL, $prefix = NULL, $customValueId = NULL, $entityId = NULL, $checkEditPermission = FALSE) { // Filter out pesky extra info unset($groupTree['info']); @@ -1988,7 +1988,7 @@ SELECT IF( EXISTS(SELECT name FROM civicrm_contact_type WHERE name like %1), 1, 'groupId', 'skipTitle', ]); - $form->assign_by_ref("{$prefix}viewCustomData", $details); + $form->assign("{$prefix}viewCustomData", $details); return $details; } } -- 2.25.1